From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3061C433B4 for ; Tue, 4 May 2021 17:47:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76822610C8 for ; Tue, 4 May 2021 17:47:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76822610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.122648.231344 (Exim 4.92) (envelope-from ) id 1ldz8k-0005VP-6t; Tue, 04 May 2021 17:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 122648.231344; Tue, 04 May 2021 17:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldz8k-0005VI-3q; Tue, 04 May 2021 17:47:22 +0000 Received: by outflank-mailman (input) for mailman id 122648; Tue, 04 May 2021 17:47:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ldz8j-0005VC-0k for xen-devel@lists.xenproject.org; Tue, 04 May 2021 17:47:21 +0000 Received: from hera.aquilenet.fr (unknown [185.233.100.1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b795809-35b4-40da-9382-d2fe0a56d345; Tue, 04 May 2021 17:47:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B66EE1E8; Tue, 4 May 2021 19:47:18 +0200 (CEST) Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h1G5CTwCoOK3; Tue, 4 May 2021 19:47:18 +0200 (CEST) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1BE7490; Tue, 4 May 2021 19:47:18 +0200 (CEST) Received: from samy by begin with local (Exim 4.94) (envelope-from ) id 1ldz8f-00GPn2-9z; Tue, 04 May 2021 19:47:17 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b795809-35b4-40da-9382-d2fe0a56d345 X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Date: Tue, 4 May 2021 19:47:17 +0200 From: Samuel Thibault To: Jason Andryuk Cc: xen-devel , Daniel De Graaf , Quan Xu Subject: Re: [PATCH 9/9] vtpmmgr: Support GetRandom passthrough on TPM 2.0 Message-ID: <20210504174717.yzvqyc37twoitlns@begin> Mail-Followup-To: Samuel Thibault , Jason Andryuk , xen-devel , Daniel De Graaf , Quan Xu References: <20210504124842.220445-1-jandryuk@gmail.com> <20210504124842.220445-10-jandryuk@gmail.com> <20210504133332.pt56xjrxvbnz2htd@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: B66EE1E8 X-Spamd-Result: default: False [-2.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; BAYES_HAM(-3.00)[100.00%] Jason Andryuk, le mar. 04 mai 2021 13:23:57 -0400, a ecrit: > > > @@ -842,6 +889,7 @@ TPM_RESULT vtpmmgr_handle_cmd( > > > switch(ord) { > > > case TPM_ORD_GetRandom: > > > vtpmloginfo(VTPM_LOG_VTPM, "Passthrough: TPM_GetRandom\n"); > > > + return vtpmmgr_handle_getrandom(opaque, tpmcmd); > > > break; > > > > Drop the break, then. I would say also move (or drop) the log, like the > > other cases. > > Will drop the break. I would just leave the log since it matches the > other cases in this case statement. Mmm, right these are all pass-through cases so better log them the same. Samuel