From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
bertrand.marquis@arm.com, wei.chen@arm.com
Subject: [PATCH v3 03/10] arm: Modify type of actlr to register_t
Date: Wed, 5 May 2021 09:43:01 +0200 [thread overview]
Message-ID: <20210505074308.11016-4-michal.orzel@arm.com> (raw)
In-Reply-To: <20210505074308.11016-1-michal.orzel@arm.com>
AArch64 registers are 64bit whereas AArch32 registers
are 32bit or 64bit. MSR/MRS are expecting 64bit values thus
we should get rid of helpers READ/WRITE_SYSREG32
in favour of using READ/WRITE_SYSREG.
We should also use register_t type when reading sysregs
which can correspond to uint64_t or uint32_t.
Even though many AArch64 registers have upper 32bit reserved
it does not mean that they can't be widen in the future.
ACTLR_EL1 system register bits are implementation defined
which means it is possibly a latent bug on current HW as the CPU
implementer may already have decided to use the top 32bit.
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v2:
-Modify the commit message
---
xen/arch/arm/domain.c | 2 +-
xen/include/asm-arm/domain.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 621f518b83..c021a03c61 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -330,7 +330,7 @@ static void schedule_tail(struct vcpu *prev)
static void continue_new_vcpu(struct vcpu *prev)
{
- current->arch.actlr = READ_SYSREG32(ACTLR_EL1);
+ current->arch.actlr = READ_SYSREG(ACTLR_EL1);
processor_vcpu_initialise(current);
schedule_tail(prev);
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index c6b59ee755..2d4f38c669 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -156,7 +156,7 @@ struct arch_vcpu
/* Control Registers */
register_t sctlr;
- uint32_t actlr;
+ register_t actlr;
uint32_t cpacr;
uint32_t contextidr;
--
2.29.0
next prev parent reply other threads:[~2021-05-05 7:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 7:42 [PATCH v3 00/10] arm64: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 7:42 ` [PATCH v3 01/10] arm64/vfp: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 02/10] arm/domain: " Michal Orzel
2021-05-05 18:03 ` Julien Grall
2021-05-06 6:13 ` Michal Orzel
2021-05-10 17:02 ` Julien Grall
2021-05-05 7:43 ` Michal Orzel [this message]
2021-05-05 18:04 ` [PATCH v3 03/10] arm: Modify type of actlr to register_t Julien Grall
2021-05-05 7:43 ` [PATCH v3 04/10] arm/gic: Remove member hcr of structure gic_v3 Michal Orzel
2021-05-05 7:43 ` [PATCH v3 05/10] arm/gic: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 18:06 ` Julien Grall
2021-05-05 7:43 ` [PATCH v3 06/10] arm/p2m: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 07/10] xen/arm: Always access SCTLR_EL2 using READ/WRITE_SYSREG() Michal Orzel
2021-05-05 18:07 ` Julien Grall
2021-05-05 7:43 ` [PATCH v3 08/10] arm/page: Get rid of READ/WRITE_SYSREG32 Michal Orzel
2021-05-05 7:43 ` [PATCH v3 09/10] arm/time,vtimer: " Michal Orzel
2021-05-05 7:43 ` [PATCH v3 10/10] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t Michal Orzel
2021-05-05 8:00 ` Jan Beulich
2021-05-05 11:49 ` Tamas K Lengyel
2021-05-11 6:37 ` Michal Orzel
2021-05-12 17:59 ` Julien Grall
2021-05-12 18:14 ` Andrew Cooper
2021-05-17 7:01 ` Jan Beulich
2021-05-17 16:03 ` Julien Grall
2021-05-21 6:33 ` Michal Orzel
2021-05-21 7:07 ` Jan Beulich
2021-06-07 13:16 ` Michal Orzel
2021-06-07 13:31 ` Julien Grall
2021-07-01 8:19 ` Michal Orzel
2021-07-03 14:42 ` Julien Grall
2021-05-10 17:19 ` [PATCH v3 00/10] arm64: Get rid of READ/WRITE_SYSREG32 Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505074308.11016-4-michal.orzel@arm.com \
--to=michal.orzel@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).