xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] automation: save xen config before building
@ 2021-05-05 11:45 Wei Liu
  2021-05-05 12:23 ` Roger Pau Monné
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2021-05-05 11:45 UTC (permalink / raw)
  To: Xen Development List
  Cc: Roger Pau Monné, Andrew Cooper, Wei Liu, Doug Goldstein

It is reported that failed randconfig runs are missing the config file
which makes debugging impossible. Fix this by moving the line that
copies the config file before the build is executed.

Signed-off-by: Wei Liu <wl@xen.org>
---
 automation/scripts/build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/automation/scripts/build b/automation/scripts/build
index eaf70b11d1cb..46b6903d2922 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -16,6 +16,10 @@ else
     make -j$(nproc) -C xen defconfig
 fi
 
+# Save the config file before building because build failure causes the script
+# to exit early -- bash is invoked with -e.
+cp xen/.config xen-config
+
 # arm32 only cross-compiles the hypervisor
 if [[ "${XEN_TARGET_ARCH}" = "arm32" ]]; then
     hypervisor_only="y"
@@ -59,7 +63,6 @@ else
 fi
 
 # Extract artifacts to avoid getting rewritten by customised builds
-cp xen/.config xen-config
 mkdir binaries
 if [[ "${XEN_TARGET_ARCH}" != "x86_32" ]]; then
     cp xen/xen binaries/xen
-- 
2.30.2



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] automation: save xen config before building
  2021-05-05 11:45 [PATCH] automation: save xen config before building Wei Liu
@ 2021-05-05 12:23 ` Roger Pau Monné
  2021-05-05 14:24   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Pau Monné @ 2021-05-05 12:23 UTC (permalink / raw)
  To: Wei Liu; +Cc: Xen Development List, Andrew Cooper, Doug Goldstein

On Wed, May 05, 2021 at 11:45:16AM +0000, Wei Liu wrote:
> It is reported that failed randconfig runs are missing the config file
> which makes debugging impossible. Fix this by moving the line that
> copies the config file before the build is executed.
> 
> Signed-off-by: Wei Liu <wl@xen.org>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] automation: save xen config before building
  2021-05-05 12:23 ` Roger Pau Monné
@ 2021-05-05 14:24   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2021-05-05 14:24 UTC (permalink / raw)
  To: Roger Pau Monné
  Cc: Wei Liu, Xen Development List, Andrew Cooper, Doug Goldstein

On Wed, May 05, 2021 at 02:23:37PM +0200, Roger Pau Monné wrote:
> On Wed, May 05, 2021 at 11:45:16AM +0000, Wei Liu wrote:
> > It is reported that failed randconfig runs are missing the config file
> > which makes debugging impossible. Fix this by moving the line that
> > copies the config file before the build is executed.
> > 
> > Signed-off-by: Wei Liu <wl@xen.org>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

A patchew run shows this indeed fixes the issue. I've pushed this to
staging.

Wei.

> 
> Thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-05 14:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 11:45 [PATCH] automation: save xen config before building Wei Liu
2021-05-05 12:23 ` Roger Pau Monné
2021-05-05 14:24   ` Wei Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).