* [PATCH v1] tools: add newlines to xenstored WRL_LOG @ 2021-05-03 15:47 Olaf Hering 2021-05-10 7:31 ` Juergen Gross 0 siblings, 1 reply; 4+ messages in thread From: Olaf Hering @ 2021-05-03 15:47 UTC (permalink / raw) To: xen-devel; +Cc: Olaf Hering, Ian Jackson, Wei Liu, Juergen Gross According to syslog(3) the fmt string does not need a newline. The mini-os implementation of syslog requires the trailing newline. Other calls to syslog do include the newline already, add it also to WRL_LOG. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- tools/xenstore/xenstored_domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c index 3d4d0649a2..2d333b3ff6 100644 --- a/tools/xenstore/xenstored_domain.c +++ b/tools/xenstore/xenstored_domain.c @@ -1132,10 +1132,10 @@ void wrl_apply_debit_actual(struct domain *domain) if (domain->wrl_credit < 0) { if (!domain->wrl_delay_logged) { domain->wrl_delay_logged = true; - WRL_LOG(now, "domain %ld is affected", + WRL_LOG(now, "domain %ld is affected\n", (long)domain->domid); } else if (!wrl_log_last_warning) { - WRL_LOG(now, "rate limiting restarts"); + WRL_LOG(now, "rate limiting restarts\n"); } wrl_log_last_warning = now.sec; } @@ -1145,7 +1145,7 @@ void wrl_log_periodic(struct wrl_timestampt now) { if (wrl_log_last_warning && (now.sec - wrl_log_last_warning) > WRL_LOGEVERY) { - WRL_LOG(now, "not in force recently"); + WRL_LOG(now, "not in force recently\n"); wrl_log_last_warning = 0; } } ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: add newlines to xenstored WRL_LOG 2021-05-03 15:47 [PATCH v1] tools: add newlines to xenstored WRL_LOG Olaf Hering @ 2021-05-10 7:31 ` Juergen Gross 2021-05-10 8:34 ` Olaf Hering 0 siblings, 1 reply; 4+ messages in thread From: Juergen Gross @ 2021-05-10 7:31 UTC (permalink / raw) To: Olaf Hering, xen-devel; +Cc: Ian Jackson, Wei Liu [-- Attachment #1.1.1: Type: text/plain, Size: 362 bytes --] On 03.05.21 17:47, Olaf Hering wrote: > According to syslog(3) the fmt string does not need a newline. > The mini-os implementation of syslog requires the trailing newline. > Other calls to syslog do include the newline already, add it also to WRL_LOG. Mind doing the same for the two syslog() calls in xenstored_core.c lacking the newline? Juergen [-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --] [-- Type: application/pgp-keys, Size: 3135 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: add newlines to xenstored WRL_LOG 2021-05-10 7:31 ` Juergen Gross @ 2021-05-10 8:34 ` Olaf Hering 2021-05-10 8:38 ` Juergen Gross 0 siblings, 1 reply; 4+ messages in thread From: Olaf Hering @ 2021-05-10 8:34 UTC (permalink / raw) To: Juergen Gross; +Cc: xen-devel, Ian Jackson, Wei Liu [-- Attachment #1: Type: text/plain, Size: 224 bytes --] Am Mon, 10 May 2021 09:31:41 +0200 schrieb Juergen Gross <jgross@suse.com>: > Mind doing the same for the two syslog() calls in xenstored_core.c > lacking the newline? I will send a separate patch for them. Olaf [-- Attachment #2: Digitale Signatur von OpenPGP --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] tools: add newlines to xenstored WRL_LOG 2021-05-10 8:34 ` Olaf Hering @ 2021-05-10 8:38 ` Juergen Gross 0 siblings, 0 replies; 4+ messages in thread From: Juergen Gross @ 2021-05-10 8:38 UTC (permalink / raw) To: Olaf Hering; +Cc: xen-devel, Ian Jackson, Wei Liu [-- Attachment #1.1.1: Type: text/plain, Size: 392 bytes --] On 10.05.21 10:34, Olaf Hering wrote: > Am Mon, 10 May 2021 09:31:41 +0200 > schrieb Juergen Gross <jgross@suse.com>: > >> Mind doing the same for the two syslog() calls in xenstored_core.c >> lacking the newline? > > I will send a separate patch for them. Okay, in this case you can add my Reviewed-by: Juergen Gross <jgross@suse.com> to the WRL_LOG patch. Juergen [-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --] [-- Type: application/pgp-keys, Size: 3135 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-10 8:39 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-03 15:47 [PATCH v1] tools: add newlines to xenstored WRL_LOG Olaf Hering 2021-05-10 7:31 ` Juergen Gross 2021-05-10 8:34 ` Olaf Hering 2021-05-10 8:38 ` Juergen Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).