* [PATCH] xen/arm: gic-v3: Add missing breaks gicv3_read_apr()
@ 2021-05-12 17:35 Julien Grall
2021-05-12 20:26 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2021-05-12 17:35 UTC (permalink / raw)
To: xen-devel
Cc: michal.orzel, Julien Grall, Stefano Stabellini, Julien Grall,
Volodymyr Babchuk
From: Julien Grall <jgrall@amazon.com>
Commit 78e67c99eb3f "arm/gic: Get rid of READ/WRITE_SYSREG32"
mistakenly converted all the cases in gicv3_read_apr() to fall-through.
Rather than re-instating a return per case, add the missing break and
keep a single return at the end of the fucntion.
Fixes: 78e67c99eb3f ("arm/gic: Get rid of READ/WRITE_SYSREG32")
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
xen/arch/arm/gic-v3.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index b86f04058947..9a3a175ad7d2 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1167,12 +1167,15 @@ static unsigned int gicv3_read_apr(int apr_reg)
case 0:
ASSERT(gicv3.nr_priorities > 4 && gicv3.nr_priorities < 8);
apr = READ_SYSREG(ICH_AP1R0_EL2);
+ break;
case 1:
ASSERT(gicv3.nr_priorities > 5 && gicv3.nr_priorities < 8);
apr = READ_SYSREG(ICH_AP1R1_EL2);
+ break;
case 2:
ASSERT(gicv3.nr_priorities > 6 && gicv3.nr_priorities < 8);
apr = READ_SYSREG(ICH_AP1R2_EL2);
+ break;
default:
BUG();
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm: gic-v3: Add missing breaks gicv3_read_apr()
2021-05-12 17:35 [PATCH] xen/arm: gic-v3: Add missing breaks gicv3_read_apr() Julien Grall
@ 2021-05-12 20:26 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2021-05-12 20:26 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel, michal.orzel, Julien Grall, Stefano Stabellini,
Volodymyr Babchuk
On Wed, 12 May 2021, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> Commit 78e67c99eb3f "arm/gic: Get rid of READ/WRITE_SYSREG32"
> mistakenly converted all the cases in gicv3_read_apr() to fall-through.
>
> Rather than re-instating a return per case, add the missing break and
> keep a single return at the end of the fucntion.
>
> Fixes: 78e67c99eb3f ("arm/gic: Get rid of READ/WRITE_SYSREG32")
> Signed-off-by: Julien Grall <jgrall@amazon.com>
reviewed and committed
> ---
> xen/arch/arm/gic-v3.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index b86f04058947..9a3a175ad7d2 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1167,12 +1167,15 @@ static unsigned int gicv3_read_apr(int apr_reg)
> case 0:
> ASSERT(gicv3.nr_priorities > 4 && gicv3.nr_priorities < 8);
> apr = READ_SYSREG(ICH_AP1R0_EL2);
> + break;
> case 1:
> ASSERT(gicv3.nr_priorities > 5 && gicv3.nr_priorities < 8);
> apr = READ_SYSREG(ICH_AP1R1_EL2);
> + break;
> case 2:
> ASSERT(gicv3.nr_priorities > 6 && gicv3.nr_priorities < 8);
> apr = READ_SYSREG(ICH_AP1R2_EL2);
> + break;
> default:
> BUG();
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 17:35 [PATCH] xen/arm: gic-v3: Add missing breaks gicv3_read_apr() Julien Grall
2021-05-12 20:26 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).