* Some more QEMU 6.0 fixes
@ 2021-06-28 10:01 Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Anthony PERARD @ 2021-06-28 10:01 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD
Follow-up of
[XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
to fix few missing bits.
To be backported to Xen 4.15 as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc
2021-06-28 10:01 Some more QEMU 6.0 fixes Anthony PERARD
@ 2021-06-28 10:01 ` Anthony PERARD
2021-06-29 12:11 ` Jason Andryuk
2021-06-28 10:01 ` [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Anthony PERARD
2021-07-02 14:07 ` Some more QEMU 6.0 fixes Julien Grall
2 siblings, 1 reply; 6+ messages in thread
From: Anthony PERARD @ 2021-06-28 10:01 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Ian Jackson, Wei Liu, Juergen Gross
f3f778c81769 forgot one boolean parameter.
Fixes: f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libs/light/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 5b01cf284163..7670e403a90f 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -1324,7 +1324,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
vncarg = GCSPRINTF("127.0.0.1:%d", vnc->display);
if (vnc->passwd && vnc->passwd[0]) {
- vncarg = GCSPRINTF("%s,password", vncarg);
+ vncarg = GCSPRINTF("%s,password=on", vncarg);
}
if (libxl_defbool_val(vnc->findunused)) {
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device
2021-06-28 10:01 Some more QEMU 6.0 fixes Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
@ 2021-06-28 10:01 ` Anthony PERARD
2021-06-29 12:10 ` Jason Andryuk
2021-07-02 14:07 ` Some more QEMU 6.0 fixes Julien Grall
2 siblings, 1 reply; 6+ messages in thread
From: Anthony PERARD @ 2021-06-28 10:01 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Ian Jackson, Wei Liu, Juergen Gross
Usage of 'scsi-disk' device is deprecated and removed from QEMU,
instead we need to use 'scsi-hd' for hard drives.
See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libs/light/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 7670e403a90f..dbd3c7f278f9 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
&drive_id),
flexarray_vappend(dm_args,
"-drive", drive,
- "-device", GCSPRINTF("scsi-disk,drive=%s,scsi-id=%d",
+ "-device", GCSPRINTF("scsi-hd,drive=%s,scsi-id=%d",
drive_id, disk),
NULL);
continue;
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device
2021-06-28 10:01 ` [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Anthony PERARD
@ 2021-06-29 12:10 ` Jason Andryuk
0 siblings, 0 replies; 6+ messages in thread
From: Jason Andryuk @ 2021-06-29 12:10 UTC (permalink / raw)
To: Anthony PERARD; +Cc: xen-devel, Ian Jackson, Wei Liu, Juergen Gross
On Mon, Jun 28, 2021 at 6:02 AM Anthony PERARD
<anthony.perard@citrix.com> wrote:
>
> Usage of 'scsi-disk' device is deprecated and removed from QEMU,
> instead we need to use 'scsi-hd' for hard drives.
> See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
Looks like scsi-hd is really old - qemu v0.15.
Regards,
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
@ 2021-06-29 12:11 ` Jason Andryuk
0 siblings, 0 replies; 6+ messages in thread
From: Jason Andryuk @ 2021-06-29 12:11 UTC (permalink / raw)
To: Anthony PERARD; +Cc: xen-devel, Ian Jackson, Wei Liu, Juergen Gross
On Mon, Jun 28, 2021 at 6:02 AM Anthony PERARD
<anthony.perard@citrix.com> wrote:
>
> f3f778c81769 forgot one boolean parameter.
>
> Fixes: f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option")
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Jason Andryuk <jandryuk@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Some more QEMU 6.0 fixes
2021-06-28 10:01 Some more QEMU 6.0 fixes Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Anthony PERARD
@ 2021-07-02 14:07 ` Julien Grall
2 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2021-07-02 14:07 UTC (permalink / raw)
To: Anthony PERARD, xen-devel; +Cc: Ian Jackson
Hi,
On 28/06/2021 11:01, Anthony PERARD wrote:
> Follow-up of
> [XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
> to fix few missing bits.
I have committed the series.
>
> To be backported to Xen 4.15 as well.
@Ian can you queue it for backport?
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-02 14:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 10:01 Some more QEMU 6.0 fixes Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
2021-06-29 12:11 ` Jason Andryuk
2021-06-28 10:01 ` [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Anthony PERARD
2021-06-29 12:10 ` Jason Andryuk
2021-07-02 14:07 ` Some more QEMU 6.0 fixes Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).