From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device
Date: Mon, 28 Jun 2021 11:01:57 +0100 [thread overview]
Message-ID: <20210628100157.5010-3-anthony.perard@citrix.com> (raw)
In-Reply-To: <20210628100157.5010-1-anthony.perard@citrix.com>
Usage of 'scsi-disk' device is deprecated and removed from QEMU,
instead we need to use 'scsi-hd' for hard drives.
See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libs/light/libxl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
index 7670e403a90f..dbd3c7f278f9 100644
--- a/tools/libs/light/libxl_dm.c
+++ b/tools/libs/light/libxl_dm.c
@@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
&drive_id),
flexarray_vappend(dm_args,
"-drive", drive,
- "-device", GCSPRINTF("scsi-disk,drive=%s,scsi-id=%d",
+ "-device", GCSPRINTF("scsi-hd,drive=%s,scsi-id=%d",
drive_id, disk),
NULL);
continue;
--
Anthony PERARD
next prev parent reply other threads:[~2021-06-28 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 10:01 Some more QEMU 6.0 fixes Anthony PERARD
2021-06-28 10:01 ` [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc Anthony PERARD
2021-06-29 12:11 ` Jason Andryuk
2021-06-28 10:01 ` Anthony PERARD [this message]
2021-06-29 12:10 ` [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device Jason Andryuk
2021-07-02 14:07 ` Some more QEMU 6.0 fixes Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628100157.5010-3-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=iwj@xenproject.org \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).