From: Kevin Stefanov <kevin.stefanov@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Stefanov <kevin.stefanov@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 1/2] xen/kexec: Remove use of TRUE/FALSE
Date: Wed, 11 Aug 2021 13:31:34 +0100 [thread overview]
Message-ID: <20210811123135.18195-2-kevin.stefanov@citrix.com> (raw)
In-Reply-To: <20210811123135.18195-1-kevin.stefanov@citrix.com>
Whilst fixing this, also changed bool_t to bool, and use __read_mostly.
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
v2:
*Use __read_mostly
---
xen/common/kexec.c | 6 +++---
xen/include/xen/kexec.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index ebeee6405a..c63db618a7 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -35,7 +35,7 @@
#include <compat/kexec.h>
#endif
-bool_t kexecing = FALSE;
+bool __read_mostly kexecing;
/* Memory regions to store the per cpu register state etc. on a crash. */
typedef struct { Elf_Note * start; size_t size; } crash_note_range_t;
@@ -383,7 +383,7 @@ void kexec_crash(enum crash_reason reason)
if ( !test_bit(KEXEC_IMAGE_CRASH_BASE + pos, &kexec_flags) )
return;
- kexecing = TRUE;
+ kexecing = true;
if ( kexec_common_shutdown() != 0 )
return;
@@ -399,7 +399,7 @@ static long kexec_reboot(void *_image)
{
struct kexec_image *image = _image;
- kexecing = TRUE;
+ kexecing = true;
kexec_common_shutdown();
machine_reboot_kexec(image);
diff --git a/xen/include/xen/kexec.h b/xen/include/xen/kexec.h
index 9f7a912e97..e66eb6a8e5 100644
--- a/xen/include/xen/kexec.h
+++ b/xen/include/xen/kexec.h
@@ -17,7 +17,7 @@ typedef struct xen_kexec_reserve {
extern xen_kexec_reserve_t kexec_crash_area;
extern paddr_t kexec_crash_area_limit;
-extern bool_t kexecing;
+extern bool kexecing;
void set_kexec_crash_area_size(u64 system_ram);
@@ -81,7 +81,7 @@ void vmcoreinfo_append_str(const char *fmt, ...)
#else /* !CONFIG_KEXEC */
#define crashinfo_maxaddr_bits 0
-#define kexecing 0
+#define kexecing false
static inline void kexec_early_calculations(void) {}
static inline void kexec_crash(enum crash_reason reason)
--
2.25.1
next prev parent reply other threads:[~2021-08-11 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 12:31 [PATCH v2 0/2] xen: Replace uses of TRUE/FALSE Kevin Stefanov
2021-08-11 12:31 ` Kevin Stefanov [this message]
2021-08-11 12:31 ` [PATCH v2 2/2] x86/ioapic: Remove use of TRUE/FALSE/1/0 Kevin Stefanov
2021-08-11 12:41 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811123135.18195-2-kevin.stefanov@citrix.com \
--to=kevin.stefanov@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).