From: Roger Pau Monne <roger.pau@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Roger Pau Monne <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <iwj@xenproject.org>
Subject: [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional
Date: Tue, 9 Nov 2021 10:47:21 +0100 [thread overview]
Message-ID: <20211109094721.53346-1-roger.pau@citrix.com> (raw)
iPXE is only used by QEMU traditional, so make it off by default
unless QEMU traditional is enabled.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Fixes: bcf77ce510 ('configure: modify default of building rombios')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <iwj@xenproject.org>
Please run autoconf before commit.
Without this patch FreeBSD build is broken, as iPXE won't build. The
main risk would be getting the configure script runes wrong, but I
think that's fairly easy to check as it will either work on not. It's
a change in the defaults, but it basically restores the behavior
previous to disabling qemu-trad on Linux.
---
tools/configure.ac | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/configure.ac b/tools/configure.ac
index 03eb7cf146..3ac62626a5 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -130,13 +130,13 @@ AC_SUBST(qemu_traditional)
AC_ARG_ENABLE([ipxe],
AS_HELP_STRING([--enable-ipxe],
- [Enable in-tree IPXE, (DEFAULT is on for x86,
- otherwise off, see also --with-system-ipxe)]),,[
- case "$host_cpu" in
- i[[3456]]86|x86_64)
- enable_ipxe="yes";;
- *) enable_ipxe="no";;
- esac
+ [Enable in-tree IPXE,
+ (DEFAULT is off, see also --with-system-ipxe)]),,[
+ AS_IF([test "x$enable_qemu_traditional" = "xyes"], [
+ enable_ipxe="yes"
+ ], [
+ enable_ipxe="no"
+ ])
])
AS_IF([test "x$enable_ipxe" = "xno"], [ipxe=n], [ipxe=y])
AC_ARG_WITH([system-ipxe],
--
2.33.0
next reply other threads:[~2021-11-09 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 9:47 Roger Pau Monne [this message]
2021-11-09 10:52 ` [PATCH for-4.16] tools/configure: make iPXE dependent on QEMU traditional Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109094721.53346-1-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).