* [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name
@ 2020-01-10 21:18 Lars Kurth
2020-01-15 18:11 ` Lars Kurth
0 siblings, 1 reply; 3+ messages in thread
From: Lars Kurth @ 2020-01-10 21:18 UTC (permalink / raw)
To: xen-devel; +Cc: jgross, Lars Kurth
From: Lars Kurth <lars.kurth@citrix.com>
Prior to this change e-mail addresses of the form "display name
<email>" would result into empty output. Also see
https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
CC: jgross@suse.com
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2e661f47d8..48e07370e8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1073,7 +1073,7 @@ sub add_categories {
my $ptype = $1;
my $pvalue = $2;
if ($ptype eq "L") {
- my $list_address = $pvalue;
+ my ($list_name, $list_address) = parse_email($pvalue);
my $list_additional = "";
my $list_role = get_list_role($i);
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name
2020-01-10 21:18 [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name Lars Kurth
@ 2020-01-15 18:11 ` Lars Kurth
2020-01-16 16:04 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Lars Kurth @ 2020-01-15 18:11 UTC (permalink / raw)
To: Lars Kurth, xen-devel; +Cc: jgross, Ian Jackson, committers, Julien Grall
I should have added more people to this change. The issue without this fix is that entries such as
L: xen-devel <xen-devel@lists.xenproject.org>
break get_maintainer.pl and thus add_maintainers.pl
Lars
On 10/01/2020, 21:19, "Lars Kurth" <lars.kurth@xenproject.org> wrote:
From: Lars Kurth <lars.kurth@citrix.com>
Prior to this change e-mail addresses of the form "display name
<email>" would result into empty output. Also see
https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html
Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
CC: jgross@suse.com
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2e661f47d8..48e07370e8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1073,7 +1073,7 @@ sub add_categories {
my $ptype = $1;
my $pvalue = $2;
if ($ptype eq "L") {
- my $list_address = $pvalue;
+ my ($list_name, $list_address) = parse_email($pvalue);
my $list_additional = "";
my $list_role = get_list_role($i);
--
2.13.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name
2020-01-15 18:11 ` Lars Kurth
@ 2020-01-16 16:04 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2020-01-16 16:04 UTC (permalink / raw)
To: Lars Kurth, Lars Kurth, xen-devel; +Cc: jgross, Ian Jackson, committers
Hi Lars,
On 15/01/2020 18:11, Lars Kurth wrote:
> I should have added more people to this change. The issue without this fix is that entries such as
>
> L: xen-devel <xen-devel@lists.xenproject.org>
>
> break get_maintainer.pl and thus add_maintainers.pl
>
> Lars
>
> On 10/01/2020, 21:19, "Lars Kurth" <lars.kurth@xenproject.org> wrote:
>
> From: Lars Kurth <lars.kurth@citrix.com>
>
> Prior to this change e-mail addresses of the form "display name
> <email>" would result into empty output. Also see
> https://lists.xenproject.org/archives/html/xen-devel/2020-01/msg00753.html
>
> Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
Reviewed-by: Julien Grall <julien@xen.org>
Cheers,
> ---
> CC: jgross@suse.com
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 2e661f47d8..48e07370e8 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1073,7 +1073,7 @@ sub add_categories {
> my $ptype = $1;
> my $pvalue = $2;
> if ($ptype eq "L") {
> - my $list_address = $pvalue;
> + my ($list_name, $list_address) = parse_email($pvalue);
> my $list_additional = "";
> my $list_role = get_list_role($i);
>
> --
> 2.13.0
>
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-16 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 21:18 [Xen-devel] [PATCH] get-maintainer.pl: Dont fall over when L: contains a display name Lars Kurth
2020-01-15 18:11 ` Lars Kurth
2020-01-16 16:04 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).