From: Sergey Dyasli <sergey.dyasli@citrix.com>
To: "Jürgen Groß" <jgross@suse.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
"sergey.dyasli@citrix.com >> Sergey Dyasli"
<sergey.dyasli@citrix.com>, Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [Xen-devel] Core Scheduling "lock == schedule_lock" assertion failure
Date: Thu, 13 Feb 2020 14:19:13 +0000 [thread overview]
Message-ID: <2089842c-1ce5-9cbb-70c1-9b1d4055a64a@citrix.com> (raw)
In-Reply-To: <2a007257-1b8e-dda9-9228-24c2a8ea5200@suse.com>
On 12/02/2020 12:24, Jürgen Groß wrote:
> On 12.02.20 12:21, Sergey Dyasli wrote:
>> Hi Juergen,
>>
>> Recently our testing has found a host crash which is reproducible.
>> Do you have any idea what might be going on here?
>
> Oh, nice catch!
>
> The problem is that get_cpu_idle_time() is calling vcpu_runstate_get()
> for an idle vcpu. This is fragile as idle vcpus are sometimes assigned
> temporarily to normal scheduling units, thus the ASSERT() in the unlock
> function is failing when the assignment of the idle vcpu is modified
> under the feet of vcpu_runstate_get() and the unit it has been assigned
> to before is already scheduled on another cpu.
>
> The patch is rather easy, though. Can you try it, please?
Thank you for the patch! I put it into testing yesterday and it looks
good so far. It also seems that the issue is well understood and the
patch should go into the main tree.
--
Sergey
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-13 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 11:21 [Xen-devel] Core Scheduling "lock == schedule_lock" assertion failure Sergey Dyasli
2020-02-12 12:24 ` Jürgen Groß
2020-02-13 14:19 ` Sergey Dyasli [this message]
2020-02-13 14:20 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2089842c-1ce5-9cbb-70c1-9b1d4055a64a@citrix.com \
--to=sergey.dyasli@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dfaggioli@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).