From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH V2] libxl: Increase device model startup
	timeout to 1min.
Date: Tue, 7 Jul 2015 15:41:00 +0100
Message-ID: <21915.58620.948343.728555@mariner.uk.xensource.com>
References: <21915.55435.416405.644342@mariner.uk.xensource.com>
	<1436279828-17246-1-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436279828-17246-1-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Anthony PERARD writes ("[PATCH V2] libxl: Increase device model startup timeout to 1min."):
> On a busy host, QEMU may take more than 10s to load and start.
> 
> This is likely due to a bug in Linux where the I/O subsystem sometime
> produce high latency under load and result in QEMU taking a long time to
> load every single dynamic libraries.

Please

>  #define LIBXL_HOTPLUG_TIMEOUT 10
> -#define LIBXL_DEVICE_MODEL_START_TIMEOUT 10
> +#define LIBXL_DEVICE_MODEL_START_TIMEOUT 60
>  #define LIBXL_STUBDOM_START_TIMEOUT 30

can that information be in a comment in the code, as well as in a
commit message ?

Thanks,
Ian.