From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource Date: Mon, 13 Jul 2015 18:18:02 +0100 Message-ID: <21923.62154.104147.29222@mariner.uk.xensource.com> References: <1436551257-28887-1-git-send-email-wei.liu2@citrix.com> <1436551257-28887-5-git-send-email-wei.liu2@citrix.com> <1436781924.7019.66.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZEhMl-00063N-GC for xen-devel@lists.xenproject.org; Mon, 13 Jul 2015 17:18:07 +0000 In-Reply-To: <1436781924.7019.66.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Xen-devel , Wei Liu , Andrew Cooper List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH 4/9] libxl: dispose dominfo to avoid leaking resource"): > On Fri, 2015-07-10 at 19:00 +0100, Wei Liu wrote: > > Add libxl_dominfo_dispose to one return path that doesn't have it. > > > > Signed-off-by: Wei Liu > > That return is a bit at odds with the generally correct error handling > in that function, but this improves things at least a little and I can > sort of see why this a slightly special case, so: I think this should be done by changing `return' to `goto out_success' or some such. Ian.