From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 05/10] libxl: localtime(3) can return NULL
Date: Tue, 14 Jul 2015 18:22:37 +0100 [thread overview]
Message-ID: <21925.17757.694183.365186@mariner.uk.xensource.com> (raw)
In-Reply-To: <1436892073-14186-6-git-send-email-wei.liu2@citrix.com>
Wei Liu writes ("[PATCH v3 05/10] libxl: localtime(3) can return NULL"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
...
> t = time(NULL);
> tm = localtime(&t);
>
> + if (!tm) {
> + ret = ERROR_FAIL;
You must log something here I think. Otherwise this function
generates ERROR_FAIL entirely mysteriously (in this quite unlikely
error path).
Ian.
next prev parent reply other threads:[~2015-07-14 17:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 16:41 [PATCH v3 00/10] xl/libxl: fix issues discovered by coverity Wei Liu
2015-07-14 16:41 ` [PATCH v3 01/10] libxl: don't check s!=NULL in libxl__abs_path Wei Liu
2015-07-14 17:19 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 02/10] libxl: turn two malloc's to libxl__malloc Wei Liu
2015-07-14 17:19 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 03/10] libxl: make libxl__strdup handle NULL Wei Liu
2015-07-14 17:21 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 04/10] libxl: avoid leaking in libxl__initia_device_remove Wei Liu
2015-07-14 17:21 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 05/10] libxl: localtime(3) can return NULL Wei Liu
2015-07-14 17:22 ` Ian Jackson [this message]
2015-07-14 16:41 ` [PATCH v3 06/10] libxl: qmp_init_handler " Wei Liu
2015-07-14 17:23 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 07/10] xl: correct handling of extra_config in main_cpupoolcreate Wei Liu
2015-07-14 17:23 ` Ian Jackson
2015-09-11 10:59 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 08/10] xl: correctly handle null extra config in main_config_update Wei Liu
2015-07-14 17:23 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 09/10] xl: fix a typo in error string in create_domain Wei Liu
2015-07-14 17:24 ` Ian Jackson
2015-07-14 16:41 ` [PATCH v3 10/10] libxl: fix caller of libxl_cpupool functions Wei Liu
2015-07-14 17:33 ` Ian Jackson
2015-07-15 17:16 ` Wei Liu
2015-07-16 8:57 ` Dario Faggioli
2015-07-16 9:07 ` Wei Liu
2015-07-16 9:33 ` Juergen Gross
2015-07-16 9:30 ` Juergen Gross
2015-07-16 12:49 ` Dario Faggioli
2015-07-15 10:23 ` [PATCH v3 00/10] xl/libxl: fix issues discovered by coverity Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21925.17757.694183.365186@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).