From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM
Date: Tue, 21 Jul 2015 16:09:05 +0100 [thread overview]
Message-ID: <21934.24721.304399.773580@mariner.uk.xensource.com> (raw)
In-Reply-To: <55AE492D.7080204@intel.com>
Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM"):
> +static void
> +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config,
> + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy)
> +{
> + d_config->num_rdms++;
> + d_config->rdms = libxl__realloc(NOGC, d_config->rdms,
> + d_config->num_rdms * sizeof(libxl_device_rdm));
> +
> + d_config->rdms[d_config->num_rdms - 1].start = rdm_start;
> + d_config->rdms[d_config->num_rdms - 1].size = rdm_size;
> + d_config->rdms[d_config->num_rdms - 1].policy = rdm_policy;
> +}
But, I wrote:
Can I suggest a function
void add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config,
uint64_t rdm_start, uint64_t rdm_size, int rdm_policy)
which assumes that d_config->num_rdms is set correctly, and increments
it ?
(Please put the increment at the end so that the assignments are to
->rdms[d_config->num_rdms], or perhaps make a convenience alias.)
Note the last paragraph.
This is now the third time I have posted that text. It is the fifth
request or clarification I have had to make about this very small
area. I have to say that I'm finding this rather frustrating.
Ian.
next prev parent reply other threads:[~2015-07-21 15:09 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 6:16 [v10][PATCH 00/16] Fix RMRR Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 02/16] xen/vtd: create RMRR mapping Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 04/16] xen: enable XENMEM_memory_map in hvm Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 05/16] hvmloader: get guest memory map into memory_map[] Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs Tiejun Chen
2015-07-20 11:00 ` George Dunlap
2015-07-20 11:30 ` Jan Beulich
2015-07-20 12:52 ` George Dunlap
2015-07-20 14:06 ` Chen, Tiejun
2015-07-20 14:10 ` George Dunlap
2015-07-20 14:16 ` Jan Beulich
2015-07-20 14:32 ` Chen, Tiejun
2015-07-20 15:00 ` Jan Beulich
2015-07-21 0:53 ` Chen, Tiejun
2015-07-21 6:18 ` Jan Beulich
2015-07-21 9:42 ` George Dunlap
2015-07-20 6:16 ` [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table Tiejun Chen
2015-07-20 11:56 ` Jan Beulich
2015-07-20 14:35 ` Chen, Tiejun
2015-07-20 15:03 ` Jan Beulich
2015-07-20 13:00 ` George Dunlap
2015-07-20 13:23 ` Chen, Tiejun
2015-07-20 13:50 ` George Dunlap
2015-07-20 13:57 ` Chen, Tiejun
2015-07-20 6:16 ` [v10][PATCH 08/16] tools/libxc: Expose new hypercall xc_reserved_device_memory_map Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 09/16] tools: extend xc_assign_device() to support rdm reservation policy Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 10/16] tools: introduce some new parameters to set rdm policy Tiejun Chen
2015-07-20 6:16 ` [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM Tiejun Chen
2015-07-20 13:32 ` Ian Jackson
2015-07-20 14:40 ` Chen, Tiejun
2015-07-20 14:53 ` Ian Jackson
2015-07-20 15:08 ` Chen, Tiejun
2015-07-20 15:24 ` Ian Jackson
2015-07-20 15:38 ` Ian Campbell
2015-07-21 6:44 ` Chen, Tiejun
2015-07-21 6:45 ` Chen, Tiejun
2015-07-21 6:38 ` Chen, Tiejun
2015-07-21 10:48 ` Ian Jackson
2015-07-21 11:12 ` Chen, Tiejun
2015-07-21 10:41 ` Ian Jackson
2015-07-21 11:04 ` Chen, Tiejun
2015-07-21 11:11 ` Ian Jackson
2015-07-21 11:23 ` Chen, Tiejun
2015-07-21 11:27 ` Ian Jackson
2015-07-21 11:45 ` Chen, Tiejun
2015-07-21 12:33 ` Ian Jackson
2015-07-21 13:29 ` Chen, Tiejun
2015-07-21 15:09 ` Ian Jackson [this message]
2015-07-21 15:42 ` Chen, Tiejun
2015-07-21 15:57 ` Ian Jackson
2015-07-21 15:57 ` Ian Jackson
2015-07-22 0:33 ` Chen, Tiejun
2015-07-22 8:43 ` Ian Campbell
2015-07-22 9:18 ` Chen, Tiejun
2015-07-22 10:28 ` Ian Jackson
2015-07-22 10:51 ` Ian Campbell
2015-07-21 13:41 ` Chen, Tiejun
2015-07-21 15:10 ` Ian Jackson
2015-07-21 15:22 ` Chen, Tiejun
2015-07-21 15:31 ` Ian Jackson
2015-07-21 12:04 ` Chen, Tiejun
2015-07-21 12:34 ` Ian Jackson
2015-07-20 6:16 ` [v10][PATCH 12/16] tools: introduce a new parameter to set a predefined rdm boundary Tiejun Chen
2015-07-20 6:17 ` [v10][PATCH 13/16] libxl: construct e820 map with RDM information for HVM guest Tiejun Chen
2015-07-20 13:34 ` Ian Jackson
2015-07-20 6:17 ` [v10][PATCH 14/16] xen/vtd: enable USB device assignment Tiejun Chen
2015-07-20 6:17 ` [v10][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr Tiejun Chen
2015-07-20 6:17 ` [v10][PATCH 16/16] tools: parse to enable new rdm policy parameters Tiejun Chen
2015-07-20 13:43 ` Ian Jackson
2015-07-20 13:53 ` Chen, Tiejun
2015-07-20 10:37 ` [v10][PATCH 00/16] Fix RMRR George Dunlap
2015-07-20 12:39 ` Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21934.24721.304399.773580@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).