From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [v10][PATCH 11/16] tools/libxl: detect and avoid
	conflicts with RDM
Date: Tue, 21 Jul 2015 11:41:48 +0100
Message-ID: <21934.8684.318670.874156@mariner.uk.xensource.com>
References: <1437373023-14884-1-git-send-email-tiejun.chen@intel.com>
	<1437373023-14884-12-git-send-email-tiejun.chen@intel.com>
	<21932.63595.566823.211293@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21932.63595.566823.211293@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tiejun Chen <tiejun.chen@intel.com>, xen-devel@lists.xen.org, Stefano
	Stabellini <stefano.stabellini@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

I wrote:
> If the domain configuration has rdms and num_rdms already set, then
> the strategy should presumably be ignored.  (Passing the same domain
> configuration struct to libxl_domain_create_new, after destroying the
> domain, ought to work, even after the first call has modified it.)

But even your latest patch adds the host rdm's (from the strategy
algorithm) to the array, unconditionally.

I think you need to think more clearly about what happens when the
caller *both* supplies some rdms, and sets strategy=host.

Certainly if this happens and the set of rdms supplied is the same as
that which would be generated by the strategy, the set should not be
duplicated.

Ian.