From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST 2/3] ts-debian-hvm-install:
	di_installcmdline_core
Date: Fri, 24 Jul 2015 18:11:27 +0100
Message-ID: <21938.29119.239475.933315@mariner.uk.xensource.com>
References: <1437405207.17368.43.camel@citrix.com>
	<1437405238-22781-2-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437405238-22781-2-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("[PATCH OSSTEST 2/3] ts-debian-hvm-install: di_installcmdline_core"):
> This is primarily to get DEBIAN_FRONTEND=test, for easier to read
> logging.
...
>  sub grub_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +					    PreseedScheme => 'file');
> +    push @dicmdline, "--";
...
>  sub isolinux_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +					    PreseedScheme => 'file');
> +    push @dicmdline, "initrd=/install.amd/initrd.gz";
> +    push @dicmdline, "--";
>      # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762007 for
>      # why console= is repeated.
> +    push @dicmdline, $gconsole;
> +
> +    my $cmdline = join(" ", @dicmdline);

These are uncomfortably similar, don't you think ?

Ian.