From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH v2 2/2] cambridge: arrange to test each new
 baseline
Date: Wed, 12 Aug 2015 16:46:51 +0100
Message-ID: <21963.27243.742209.864679@mariner.uk.xensource.com>
References: <1437994504-10604-1-git-send-email-ian.campbell@citrix.com>
	<1437994504-10604-2-git-send-email-ian.campbell@citrix.com>
	<1439388539.8356.32.camel@citrix.com>	<1439393233.8356.53.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1439393233.8356.53.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Ian Campbell writes ("Re: [Xen-devel] [PATCH v2 2/2] cambridge: arrange to test each new baseline"):
> diff --git a/cr-daily-branch b/cr-daily-branch
> index 4b9b525..f9edbd4 100755
> --- a/cr-daily-branch
> +++ b/cr-daily-branch
> @@ -100,6 +100,13 @@ if [ "x$OSSTEST_BASELINES_ONLY" = xy ] ; then
>      force_baseline=baselines-only
>      wantpush=false
>      skipidentical=true
> +    if [ "x$treeurl" != xnone: ]; then
> +	treearg=--tree-$tree=$treeurl
> +    fi
> +    tested_revision=`check_tested $treearg --print-revision=$tree`
> +    if [ "x$tested_revision" != x ]; then
> +	OLD_REVISION="$tested_revision"
> +    fi

This is strikingly similar to the code inside
   if [ "x$OSSTEST_NO_BASELINE" != xy ] ; then
near line 99.

Maybe, instead, you should nobble the
     if [ "x$OLD_REVISION" = x ]; then
bit which sets OLD_REVISION, somehow, and then the later code is
nearly right.

Ian.