From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4 2/5] libxl: Fix libxl_set_memory_target return value
Date: Tue, 5 Jan 2016 15:21:26 +0000 [thread overview]
Message-ID: <22155.57206.666366.700254@mariner.uk.xensource.com> (raw)
In-Reply-To: <1452005680.13361.302.camel@citrix.com>
Ian Campbell writes ("Re: [PATCH v4 2/5] libxl: Fix libxl_set_memory_target return value"):
> On Mon, 2016-01-04 at 17:37 +0000, Ian Jackson wrote:
> > Can you go back to `lrc' for just that one use ? I think that would
> > be analogous with CODING_STYLE's suggestion to use `rc' for libxl
> > error codes.
>
> I was never quite sure what the "l" was supposed to reference, local?
It seems to mean `local' to me. I was going to suggest `lrc' for this
variable name even before I saw that it had already been `lrc' in a
previous patch, which suggests it's a local maximum in probability
space...
Ian.
next prev parent reply other threads:[~2016-01-05 15:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 12:23 [PATCH v4 0/5] Return failure on failure for more xl commands George Dunlap
2015-12-18 12:23 ` [PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target George Dunlap
2016-01-04 17:28 ` Ian Jackson
2016-03-24 16:54 ` George Dunlap
2015-12-18 12:23 ` [PATCH v4 2/5] libxl: Fix libxl_set_memory_target return value George Dunlap
2016-01-04 17:37 ` Ian Jackson
2016-01-05 14:54 ` Ian Campbell
2016-01-05 15:21 ` Ian Jackson [this message]
2015-12-18 12:23 ` [PATCH v4 3/5] xl: Make set_memory_target return an error code on failure George Dunlap
2015-12-21 10:52 ` Dario Faggioli
2016-01-04 17:37 ` Ian Jackson
2015-12-18 12:23 ` [PATCH v4 4/5] xl: Return an error on failed cd-insert George Dunlap
2015-12-21 10:52 ` Dario Faggioli
2016-01-04 17:38 ` Ian Jackson
2015-12-18 12:23 ` [PATCH v4 5/5] xl: Return error codes for pci* commands George Dunlap
2015-12-21 10:51 ` Dario Faggioli
2016-01-04 17:40 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22155.57206.666366.700254@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).