From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: New Defects reported by Coverity Scan for XenProject Date: Mon, 4 Apr 2016 16:07:50 +0100 Message-ID: <22274.33606.593395.44137@mariner.uk.xensource.com> References: <5700f7b3e7d5c_3fdf4db3186252@ss1435.mail> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an67F-0006ZZ-Up for xen-devel@lists.xenproject.org; Mon, 04 Apr 2016 15:08:34 +0000 In-Reply-To: <5700f7b3e7d5c_3fdf4db3186252@ss1435.mail> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: coverity@xenproject.org Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org c2Nhbi1hZG1pbkBjb3Zlcml0eS5jb20gd3JpdGVzICgiTmV3IERlZmVjdHMgcmVwb3J0ZWQgYnkg Q292ZXJpdHkgU2NhbiBmb3IgWGVuUHJvamVjdCIpOgo+IFBsZWFzZSBmaW5kIHRoZSBsYXRlc3Qg cmVwb3J0IG9uIG5ldyBkZWZlY3QocykgaW50cm9kdWNlZCB0byBYZW5Qcm9qZWN0IGZvdW5kIHdp dGggQ292ZXJpdHkgU2Nhbi4KPgo+IDM1IG5ldyBkZWZlY3QocykgaW50cm9kdWNlZCB0byBYZW5Q cm9qZWN0IGZvdW5kIHdpdGggQ292ZXJpdHkgU2Nhbi4KPiAyIGRlZmVjdChzKSwgcmVwb3J0ZWQg YnkgQ292ZXJpdHkgU2NhbiBlYXJsaWVyLCB3ZXJlIG1hcmtlZCBmaXhlZCBpbiB0aGUgcmVjZW50 IGJ1aWxkIGFuYWx5emVkIGJ5IENvdmVyaXR5IFNjYW4uCj4gCj4gTmV3IGRlZmVjdChzKSBSZXBv cnRlZC1ieTogQ292ZXJpdHkgU2Nhbgo+IFNob3dpbmcgMjAgb2YgMzUgZGVmZWN0KHMpCgpJIGhh dmUgYmVlbiB0aHJvdWdoIHRoZSB0b29scyByZXBvcnRzIGhlcmUuICBOb25lIG9mIHRoZW0gYXJl IHNlY3VyaXR5CnByb2JsZW1zIGluIHJlbGVhc2VkIGJyYW5jaGVzLgoKCkkgd291bGQgbGlrZSBz b21lIGFkdmljZSBmcm9tIENvdmVyaXR5IGV4cGVydHMgb24gdGhlIHR3byBiZWxvdzoKCgoKPiAq KiBDSUQgMTM1ODA4ODogIENvbmN1cnJlbnQgZGF0YSBhY2Nlc3MgdmlvbGF0aW9ucyAgKE1JU1NJ TkdfTE9DSykKCkFwcGxpZXMgdG8gMTM1ODA4Ni4uMTM1ODEwNSBpbmNsdXNpdmUuICBIZXJlIGlz IGEgc2FtcGxlOgoKPiAqKiogQ0lEIDEzNTgwODg6ICBDb25jdXJyZW50IGRhdGEgYWNjZXNzIHZp b2xhdGlvbnMgIChNSVNTSU5HX0xPQ0spCj4gL3Rvb2xzL2xpYnhsL2xpYnhsX2V2ZW50LmM6IDIx ODkgaW4gbGlieGxfX2FvX3Byb2dyZXNzX3JlcG9ydCgpCj4gMjE4MyAgICAgICAgIH0gZWxzZSBp ZiAoaG93LT5jYWxsYmFjaykgewo+IDIxODQgICAgICAgICAgICAgbGlieGxfX2FvcF9vY2N1cnJl ZCAqYW9wID0gbGlieGxfX3phbGxvYygmZWdjLT5nYywgc2l6ZW9mKCphb3ApKTsKPiAyMTg1ICAg ICAgICAgICAgIGFvLT5wcm9ncmVzc19yZXBvcnRzX291dHN0YW5kaW5nKys7Cj4gMjE4NiAgICAg ICAgICAgICBhb3AtPmFvID0gYW87Cj4gMjE4NyAgICAgICAgICAgICBhb3AtPmV2ID0gZXY7Cj4g MjE4OCAgICAgICAgICAgICBhb3AtPmhvdyA9IGhvdzsKPiA+Pj4gICAgIENJRCAxMzU4MDg4OiAg Q29uY3VycmVudCBkYXRhIGFjY2VzcyB2aW9sYXRpb25zICAoTUlTU0lOR19MT0NLKQo+ID4+PiAg ICAgQWNjZXNzaW5nICJlZ2MtPmFvcHNfZm9yX2NhbGxiYWNrLnRxaF9sYXN0IiB3aXRob3V0IGhv bGRpbmcgbG9jayAibGlieGxfX2N0eC5sb2NrIi4gRWxzZXdoZXJlLCAibGlieGxfX2VnYy5hb3Bz X2Zvcl9jYWxsYmFjay50cWhfbGFzdCIgaXMgYWNjZXNzZWQgd2l0aCAibGlieGxfX2N0eC5sb2Nr IiBoZWxkIDM0IG91dCBvZiA0NCB0aW1lcy4KPiAyMTg5ICAgICAgICAgICAgIExJQlhMX1RBSUxR X0lOU0VSVF9UQUlMKCZlZ2MtPmFvcHNfZm9yX2NhbGxiYWNrLCBhb3AsIGVudHJ5KTsKPiAyMTkw ICAgICAgICAgICAgIExPRyhERUJVRywiYW8gJXA6IHByb2dyZXNzIHJlcG9ydDogY2FsbGJhY2sg cXVldWVkIGFvcD0lcCIsYW8sYW9wKTsKPiAyMTkxICAgICAgICAgfSBlbHNlIHsKPiAyMTkyICAg ICAgICAgICAgIExPRyhERUJVRywiYW8gJXA6IHByb2dyZXNzIHJlcG9ydDogZXZlbnQgcXVldWVk IGV2PSVwIHR5cGU9JXMiLAo+IDIxOTMgICAgICAgICAgICAgICAgIGFvLCBldiwgbGlieGxfZXZl bnRfdHlwZV90b19zdHJpbmcoZXYtPnR5cGUpKTsKPiAyMTk0ICAgICAgICAgICAgIGxpYnhsX19l dmVudF9vY2N1cnJlZChlZ2MsIGV2KTsKClRoaXMgaXMgYSBmYWxzZSBwb3NpdGl2ZS4gIEFuIGVn YyBpcyBhbHdheXMgYWxsb2NhdGVkIG9uIHRoZSBzdGFjayBvZgp0aGUgdGhyZWFkIHRoYXQgdXNl cyBpdC4gIEl0IGlzIG9ubHkgZXZlciB1c2VkIGJ5IHRoYXQgdGhyZWFkLiAgU28KZG9lcyBub3Qg bmVlZCB0byBiZSBwcm90ZWN0ZWQgYnkgYSBsb2NrLgoKSXMgdGhlcmUgYSB3YXkgd2UgY2FuIHRl YWNoIENvdmVyaXR5IGFib3V0IHRoaXMgPwoKCgo+ICoqIENJRCAxMzU4MDg1OiAgSW5jb3JyZWN0 IGV4cHJlc3Npb24gIChJREVOVElDQUxfQlJBTkNIRVMpCj4gL3Rvb2xzL2xpYnhsL19saWJ4bF90 eXBlcy5jOiA1NjExIGluIGxpYnhsX2RldmljZV91c2JkZXZfZ2VuX2pzb24oKQoKQXBwbGllcyB0 byAxMzU4MDgxLi4xMzU4MDg0IGluY2x1c2l2ZS4KCkhlcmUgaXMgYSBzYW1wbGU6Cgo+ICoqKiBD SUQgMTM1ODA4NTogIEluY29ycmVjdCBleHByZXNzaW9uICAoSURFTlRJQ0FMX0JSQU5DSEVTKQo+ IC90b29scy9saWJ4bC9fbGlieGxfdHlwZXMuYzogNTYxMSBpbiBsaWJ4bF9kZXZpY2VfdXNiZGV2 X2dlbl9qc29uKCkKPiA1NjA1ICAgICAgICAgICAgICAgICAgICAgaWYgKHMgIT0geWFqbF9nZW5f c3RhdHVzX29rKQo+IDU2MDYgICAgICAgICAgICAgICAgICAgICAgICAgZ290byBvdXQ7Cj4gNTYw NyAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gNTYwOCAgICAgICAgICAgICB9Cj4gNTYwOSAgICAg ICAgIH0KPiA1NjEwICAgICAgICAgcyA9IHlhamxfZ2VuX21hcF9jbG9zZShoYW5kKTsKPiA+Pj4g ICAgIENJRCAxMzU4MDg1OiAgSW5jb3JyZWN0IGV4cHJlc3Npb24gIChJREVOVElDQUxfQlJBTkNI RVMpCj4gPj4+ICAgICBUaGUgc2FtZSBjb2RlIGlzIGV4ZWN1dGVkIHdoZW4gdGhlIGNvbmRpdGlv biAicyAhPSB5YWpsX2dlbl9zdGF0dXNfb2siIGlzIHRydWUgb3IgZmFsc2UsIGJlY2F1c2UgdGhl IGNvZGUgaW4gdGhlIGlmLXRoZW4gYnJhbmNoIGFuZCBhZnRlciB0aGUgaWYgc3RhdGVtZW50IGlz IGlkZW50aWNhbC4gU2hvdWxkIHRoZSBpZiBzdGF0ZW1lbnQgYmUgcmVtb3ZlZD8KPiA1NjExICAg ICAgICAgaWYgKHMgIT0geWFqbF9nZW5fc3RhdHVzX29rKQo+IDU2MTIgICAgICAgICAgICAgZ290 byBvdXQ7Cj4gNTYxMyAgICAgICAgIG91dDoKPiA1NjE0ICAgICAgICAgcmV0dXJuIHM7CgpUaGlz IGlzIGEgZmFsc2UgcG9zaXRpdmUgYXJpc2luZyBmcm9tIGF1dG9nZW5lcmF0ZWQgY29kZS4gIFRo ZQphdXRvZ2VuZXJhdGVkIGNvZGUgbmF0dXJhbGx5IGhhcyBhIGNvbXBsZXRlbHkgc3lzdGVtYXRp YyBlcnJvcgpoYW5kbGluZyBwYXR0ZXJuLCB3aGljaCBsZWFkcyB0byBpdCBzb21ldGltZXMgZG9p bmcgdGhpczoKCiAgICBpZiAoZXJyb3IpCiAgICAgICBnb3RvIG91dDsKICBvdXQ6CiAgICAvKiBl eGl0IHBhdGggKi8KCklzIHRoZXJlIGEgd2F5IHRvIGFycmFuZ2UgdG8gYWx3YXlzIHBlcnN1YWRl IENvdmVyaXR5IHRoYXQgdGhpcyBpcwppbnRlbnRpb25hbCA/CgoKVGhhbmtzLApJYW4uCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hl bi1kZXZlbAo=