xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: libvir-list@redhat.com,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Jim Fehlig <jfehlig@suse.com>,
	cardoe@cardoe.com
Subject: Re: [PATCH] libxl: libxl_domain_create_restore has an extra argument
Date: Tue, 5 Apr 2016 16:12:57 +0100	[thread overview]
Message-ID: <22275.54777.889693.883970__30033.1463026398$1459869353$gmane$org@mariner.uk.xensource.com> (raw)
In-Reply-To: <20160405142816.GC18120@citrix.com>

Wei Liu writes ("Re: [PATCH] libxl: libxl_domain_create_restore has an extra argument"):
> CC Jim as well
> 
> On Tue, Apr 05, 2016 at 03:20:12PM +0100, Wei Liu wrote:
> > In the latest libxenlight code, libxl_domain_create_restore accepts a
> > new argument. Update libvirt's libxl driver for that. Use the macro
> > provided by libxenlight to detect which version should be used.
> > 
> > The new parameter (send_back_fd) is set to -1 because libvirt provides
> > no such fd.
...
> > -#ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS
> > +#if defined(LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_BACK_FD)
> > +        params.checkpointed_stream = 0;
> > +        ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
> > +                                          restore_fd, -1, &params, NULL,
> > +                                          &aop_console_how);
> > +#elif defined(LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS)
> >          params.checkpointed_stream = 0;
> >          ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
> >                                            restore_fd, &params, NULL,

Another approach would be 

             ret = libxl_domain_create_restore(cfg->ctx, &d_config, &domid,
                                               restore_fd,
    #ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_BACK_FD
                                               -1,
    #endif
    #ifdef LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS
                                               &params,
    #endif
                                               NULL, &aop_console_how);

But which to choose is a matter of taste.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-05 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 14:20 Wei Liu
2016-04-05 14:28 ` Wei Liu
2016-04-05 15:12   ` Ian Jackson [this message]
     [not found]   ` <22275.54777.889693.883970@mariner.uk.xensource.com>
2016-04-06 11:24     ` Wei Liu
2016-04-06 21:43 ` Doug Goldstein
     [not found] ` <570582EB.4050305@cardoe.com>
2016-04-07 16:35   ` [libvirt] " Daniel P. Berrange
2016-04-07 17:44     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='22275.54777.889693.883970__30033.1463026398$1459869353$gmane$org@mariner.uk.xensource.com' \
    --to=ian.jackson@eu.citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=jfehlig@suse.com \
    --cc=libvir-list@redhat.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] libxl: libxl_domain_create_restore has an extra argument' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).