xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
Subject: Re: [PATCH 2/2] tools: detect appropriate debug optimization level
Date: Wed, 6 Apr 2016 15:07:47 +0100	[thread overview]
Message-ID: <22277.6195.666187.151661@mariner.uk.xensource.com> (raw)
In-Reply-To: <1457403820-2949-2-git-send-email-cardoe@cardoe.com>

Doug Goldstein writes ("[PATCH 2/2] tools: detect appropriate debug optimization level"):
> The build should not use -O0 as that results in miscompilations. There
> have been a few instances on the ML where users were told to switch
> from -O0 to -O1 or -O2 or to set debug=n and their issue went away. The
> preferred route should be to use -Og if its available, otherwise use
> -O1 which is the default. This change undoes the change from -O1 to -O0
> in 1166ecf781b1016eaa61f8d5ba4fb1fde9d599b6.

To summarise: I agree with using -Og if it is available.  But I
disagree with reverting 1166ecf7 in the case where it isn't; if -Og is
not available, we should stick with -O0.

I'm open to persuasion in the latter point but I would like specific
examples of problems (and then I would form an opinion about the
specific problems), not generalities.

Doug, would you like to, for now, propose a patch that uses -Og if it
is available, but otherwise falls back to -O0 ?  NB that if
convenient, this can be done simply by always specifying -O0 and
putting -Og after it if it is supported.


Xen-devel mailing list

  parent reply	other threads:[~2016-04-06 14:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  2:23 [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Doug Goldstein
2016-03-08  2:23 ` [PATCH 2/2] tools: detect appropriate debug optimization level Doug Goldstein
2016-03-08 15:38   ` Wei Liu
2016-03-08 16:34     ` Doug Goldstein
2016-03-08 16:50       ` Wei Liu
2016-03-16 19:14         ` Doug Goldstein
2016-03-28 15:01           ` Doug Goldstein
2016-03-29 11:44             ` George Dunlap
2016-03-29 17:21               ` Doug Goldstein
2016-03-30  9:52                 ` George Dunlap
2016-03-30 16:00       ` Ian Jackson
2016-03-30 16:11         ` Ian Jackson
2016-03-30 16:20         ` Doug Goldstein
2016-03-31  8:24         ` George Dunlap
2016-04-06 14:07   ` Ian Jackson [this message]
2016-04-06 14:34     ` George Dunlap
2016-04-06 14:57       ` Ian Jackson
2016-03-08 15:38 ` [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Wei Liu
2016-03-10 15:13   ` Doug Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22277.6195.666187.151661@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).