From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block Date: Wed, 6 Apr 2016 15:39:10 +0100 Message-ID: <22277.8078.574628.335090@mariner.uk.xensource.com> References: <56EB2B73.3060905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56EB2B73.3060905@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ross Philipson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Um9zcyBQaGlsaXBzb24gd3JpdGVzICgiW1hlbi1kZXZlbF0gW1BBVENIXSBibGt0YXAyOiBJbnZh bGlkIGxvZ2ljIGRldGVjdGluZyB1bmFsaWduZWQgYnVmZmVycyBpbiB2aGRfd3JpdGVfYmxvY2si KToKPiBJdCBzZWVtcyB0aGUgbG9naWMgaXMgbWVhbnQgdG8gZGV0ZWN0IHNlY3RvciB1bmFsaWdu ZWQgYnVmZmVycyBmb3IgYmxvY2sKPiB3cml0ZXMuIFRoZSBOT1Rpbmcgb2YgdGhlIGxvZ2ljIGlu c3RlYWQgbWFza3Mgb2ZmIGFueSB1bmFsaWduZWQgYml0cyBhbmQKPiBhbHNvIHdvdWxkIGNhdXNl IHRoZSBmdW5jdGlvbiB0byBhbHdheXMgZmFpbC4gSXQgc2VlbXMgdGhlIGZ1bmN0aW9uIGlzIG5v dAo+IHVzZWQgaW4gYW55IG9mIHRoZSB0b29scyBzbyB0aGF0IGlzIHByb2JhYmx5IHdoeSB0aGUg cHJvYmxlbSBpcyBub3Qgc2Vlbi4KPiBJbiB0aGUgdmhkX3JlYWRfYmxvY2sgZnVuY3Rpb24gaXQg aXMgY29ycmVjdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBSb3NzIFBoaWxpcHNvbiA8cm9zcy5waGls aXBzb25AYWluZm9zZWMuY29tPgo+IC0tLQo+IGRpZmYgLS1naXQgYS90b29scy9ibGt0YXAyL3Zo ZC9saWIvbGlidmhkLmMgYi90b29scy9ibGt0YXAyL3ZoZC9saWIvbGlidmhkLmMKPiBpbmRleCAx ZmQ1YjRlLi40ZWJlMDEyIDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2Jsa3RhcDIvdmhkL2xpYi9saWJ2 aGQuYwo+ICsrKyBiL3Rvb2xzL2Jsa3RhcDIvdmhkL2xpYi9saWJ2aGQuYwo+IEBAIC0yMTg4LDcg KzIxODgsNyBAQCB2aGRfd3JpdGVfYmxvY2sodmhkX2NvbnRleHRfdCAqY3R4LCB1aW50MzJfdCBi bG9jaywgY2hhciAqZGF0YSkKPiAgICAgICAgIGlmIChibG9jayA+PSBjdHgtPmJhdC5lbnRyaWVz KQo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVSQU5HRTsKPiAKPiAtICAgICAgIGlmICgodW5z aWduZWQgbG9uZylkYXRhICYgfihWSERfU0VDVE9SX1NJWkUgLTEpKQo+ICsgICAgICAgaWYgKCh1 bnNpZ25lZCBsb25nKWRhdGEgJiAoVkhEX1NFQ1RPUl9TSVpFIC0xKSkKCk5vdHdpdGhzdGFuZGlu ZyB0aGUgZGlzY3Vzc2lvbiBpbiB0aGUgcmVzdCBvZiB0aGUgdGhyZWFkLCB0aGlzIGlzIGEKY2xl YXJseS1jb3JyZWN0IGJ1Z2ZpeCB0byB0aGUgY29kZSBpbiB0cmVlLCBzbyBJIGhhdmUgcXVldWVk IGl0LgoKSG93ZXZlciwgSSBoYWQgdG8gZG8gc28gcmF0aGVyIG1hbnVhbGx5IGJlY2F1c2Ugc29t ZXRoaW5nIGhhZCBtYW5nbGVkCnRoZSB3aGl0ZXNwYWNlLiAgUm9zcywgY2FuIHlvdSBjaGVjayB5 b3VyIHBhdGNoIHN1Ym1pc3Npb24gcGF0aCwKcGxlYXNlID8KCklhbi4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==