xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] pygrub: Ignore GRUB2 if statements
Date: Thu, 7 Apr 2016 17:57:34 +0100	[thread overview]
Message-ID: <22278.37246.197731.817601@mariner.uk.xensource.com> (raw)
In-Reply-To: <1460038181-4463-1-git-send-email-ross.lagerwall@citrix.com>

Ross Lagerwall writes ("[PATCH 1/2] pygrub: Ignore GRUB2 if statements"):
> SLES 12's default GRUB config has the following code before any entries:
> if [ -n "$extra_cmdline" ]; then
>   submenu "Bootable snapshot #$snapshot_num" {
>     menuentry "If OK, run 'snapper rollback' and reboot." { true; }
>   }
> fi
> 
> This prevents pygrub from booting using the default entry. Since I'm not
> aware of any distro GRUB config which puts useful entries within
> conditionals, ignore them.

I think this has a risk of breaking things, doesn't it ?  I mean,
existing setups might contain `if's and the relevant parts would no
longer be processed.

So I think this isn't a backport candidate.  And really I would like
an alternative, less risky fix, which would be a backport candidate.
Can you think of an alternative approach ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      parent reply	other threads:[~2016-04-07 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 14:09 [PATCH 1/2] pygrub: Ignore GRUB2 if statements Ross Lagerwall
2016-04-07 14:09 ` [PATCH 2/2] libfsimage: Add support for btrfs Ross Lagerwall
2016-04-07 16:59   ` Ian Jackson
2016-04-07 16:57 ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22278.37246.197731.817601@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).