From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D625C433E0 for ; Fri, 31 Jul 2020 13:47:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EADA4208E4 for ; Fri, 31 Jul 2020 13:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EADA4208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1VNW-0007tr-78; Fri, 31 Jul 2020 13:47:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1VNU-0007tf-OZ for xen-devel@lists.xenproject.org; Fri, 31 Jul 2020 13:47:16 +0000 X-Inumbo-ID: 57d3fff4-d334-11ea-abb4-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 57d3fff4-d334-11ea-abb4-12813bfff9fa; Fri, 31 Jul 2020 13:47:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 21EA1B013; Fri, 31 Jul 2020 13:47:28 +0000 (UTC) Subject: Re: [PATCH] tools/configure: drop BASH configure variable [and 1 more messages] To: Andrew Cooper References: <20200722113258.3673-1-andrew.cooper3@citrix.com> <20200626170038.27650-1-andrew.cooper3@citrix.com> <880fcc83-875c-c030-bfac-c64477aa3254@suse.com> <24313.55588.61431.336617@mariner.uk.xensource.com> <2c202733-cbff-74e0-30c6-4cba227e7969@suse.com> <24356.5736.297234.341867@mariner.uk.xensource.com> From: Jan Beulich Message-ID: <2229b6be-bf37-d7d9-4b53-686e49f22eb7@suse.com> Date: Fri, 31 Jul 2020 15:47:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Daniel De Graaf , Paul Durrant , Wei Liu , Xen-devel Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31.07.2020 15:46, Andrew Cooper wrote: > On 31/07/2020 14:30, Jan Beulich wrote: >> On 31.07.2020 15:02, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"): >>>> On 29.06.2020 14:05, Ian Jackson wrote: >>>>> Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"): >>>>>> On 26.06.2020 19:00, Andrew Cooper wrote: >>>>>> ... this may or may not take effect on the file system the sources >>>>>> are stored on. >>>>> In what circumstances might this not take effect ? >>>> When the file system is incapable of recording execute permissions? >>>> It has been a common workaround for this in various projects that >>>> I've worked with to use $(SHELL) to account for that, so the actual >>>> permissions from the fs don't matter. (There may be mount options >>>> to make everything executable on such file systems, but people may >>>> be hesitant to use them.) >>> I don't think we support building from sources which have been >>> unpacked onto such filesystems. Other projects which might actually >>> need to build on Windows or something do do this $(SHELL) thing or an >>> equivalent, but I don't think that's us. >> It's not unexpected that you think of Windows here, but my thoughts >> were more towards building from sources on a CD or DVD, where iirc >> execute permissions also don't exist. The latest when we have >> out-of-tree builds fully working, this ought to be something that >> people should be able to do, imo. (Even without out-of-tree builds, >> my "next best" alternative of using a tree of symlinks to build in >> would similarly have an issue with the links pointing at a mounted >> CD/DVD, if the $(SHELL) wasn't present.) > > See v2.  I put $(SHELL) in, because it isn't a worthwhile use of our > time to continue arguing over this point. I had seen you did; I was merely replying back to Ian's comments. Jan