xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Zhenzhong Duan <zhenzhong.duan@oracle.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Fix cpumap setting before passing to XEN
Date: Mon, 25 Apr 2016 14:26:44 +0100	[thread overview]
Message-ID: <22302.6932.531611.372037@mariner.uk.xensource.com> (raw)
In-Reply-To: <20160422181552.GB31271@char.us.oracle.com>

Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] Fix cpumap setting before passing to XEN"):
> On Wed, Apr 20, 2016 at 03:33:13PM +0100, Wei Liu wrote:
> > In principle I think having python binding and xl/libxl behave more or less
> > the same is the right direction. I'm a bit nervous about the change of
> > behaviour on the other hand.
> > 
> > Let's wait for a few more days to see if other people have any comment on
> > this.
> 
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> ?

Does this bug report mean that `xm vcpu-pin ... all' has never
worked properly ?  Can that really be the case ?

Also, xm exists in Xen 4.4 and earlier, only.  Xen 4.4 is no longer
supported upstream, so we would not apply this patch to Xen 4.4.  So
whatever we do, this is not going to fix any bug in `xm vcpu-pin' in
4.4.

This doesn't necessarily mean that I object to changing the behaviour
of the python xc module in still-supported Xen releases.  But I'm not
sure the reasoning behind the behaviour of the libxl bitmap functions
applies to the Python interface.

Zhenzhong Duan, are you using an out-of-tree copy of xm and xend ?

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-04-25 13:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11  1:42 [PATCH] Fix cpumap setting before passing to XEN Zhenzhong Duan
2016-04-11 11:27 ` Wei Liu
2016-04-12  3:35   ` Zhenzhong Duan
2016-04-18  4:57     ` Zhenzhong Duan
2016-04-20 14:33     ` Wei Liu
2016-04-22 18:15       ` Konrad Rzeszutek Wilk
2016-04-25 13:26         ` Ian Jackson [this message]
2016-04-26  3:54           ` Zhenzhong Duan
2016-04-28 15:07             ` Wei Liu
2016-04-28 17:02               ` Ian Jackson
2016-05-04 20:04                 ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22302.6932.531611.372037@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zhenzhong.duan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).