From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: Restrict configuration of qemu processes
Date: Mon, 9 May 2016 17:35:38 +0100 [thread overview]
Message-ID: <22320.48218.990000.689515@mariner.uk.xensource.com> (raw)
In-Reply-To: <22259.61760.242522.705675@mariner.uk.xensource.com>
Ian Jackson writes ("Re: [Xen-devel] [PATCH] tools: Restrict configuration of qemu processes"):
> Jim Fehlig writes ("[Xen-devel] [PATCH] tools: Restrict configuration of qemu processes"):
> > Commit 6ef823fd added '-nodefaults' to the qemu args created by
> > libxl, which is a good step in restricting qemu's default
> > configuration. This change takes another step by adding
> > -no-user-config, which ignores any user-provided config files in
> > sysconfdir. Together, -nodefaults and -no-user-config allow Xen
> > to avoid unkown and uncontrolled qemu configuration.
> >
> > Both options are also added to the qemu invocation in the
> > xen-qemu-dom0-disk-backend systemd service file.
>
> Queued, thanks. Also listed for backport.
I found this on my backport todo list. Thinking about it, I have had
second thoughts.
I worry that existing users of stable branches might be relying on the
user config feature (for example by dropping qemu configuration in
~root). If they are, then applying this would break things for them.
It's not a security problem because in xen the configuration in
question would have to come from ~root.
So I think, probably, that we should leave this be (ie, not backport
the patch). Does anyone want to try to change my mind ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-09 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 1:08 [PATCH] tools: Restrict configuration of qemu processes Jim Fehlig
2016-03-15 1:14 ` Jim Fehlig
2016-03-15 12:28 ` Wei Liu
2016-03-22 20:12 ` Jim Fehlig
2016-03-24 13:53 ` Ian Jackson
2016-05-09 16:35 ` Ian Jackson [this message]
2016-05-09 22:37 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22320.48218.990000.689515@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).