From: Ian Jackson <firstname.lastname@example.org> To: Juergen Gross <email@example.com> Cc: Dario Faggioli <firstname.lastname@example.org>, email@example.com, Wei Liu <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0 Date: Tue, 14 Jun 2016 15:28:23 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <575FDCE6.email@example.com> Juergen Gross writes ("Re: [Xen-devel] [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0"): > On 14/06/16 12:07, Ian Jackson wrote: > > I looked at the code for a minute or two, and perhaps I'm being dense > > this morning, but I wasn't able to see (from the code and the commit > > message and from the diff) precisely what misunderstanding the > > original author of the code had, and how this patch fixes it. > > The problem arises if dom0 has less vcpus than a numa node. In this case > libxl_set_vcpuonline() will fail as the cpumap has more bits set than > the number of dom0's vcpus. Oh, right, of course. > My patch will result in a call of libxl_set_vcpuonline() only in case > dom0 has more vcpus online than the number of cpus of node it is to be > restricted to. That makes sense, thanks. I have made a note of this patch in my backport list. Ian. _______________________________________________ Xen-devel mailing list Xenfirstname.lastname@example.org http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-14 14:28 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-14 4:30 Juergen Gross 2016-06-14 9:01 ` Dario Faggioli 2016-06-14 9:56 ` Wei Liu 2016-06-14 9:58 ` Wei Liu 2016-06-14 10:05 ` Juergen Gross 2016-06-17 10:44 ` Wei Liu 2016-06-14 10:07 ` Ian Jackson 2016-06-14 10:31 ` Juergen Gross 2016-06-14 14:28 ` Ian Jackson [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] libxl: correct xl cpupool-numa-split with vcpu limited dom0' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).