From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: [PATCH 2/2] xenstore: use temporary memory context for firing watches
Date: Fri, 15 Jul 2016 17:21:05 +0100 [thread overview]
Message-ID: <22409.3441.478715.747975@mariner.uk.xensource.com> (raw)
In-Reply-To: <1468558636-17373-3-git-send-email-jgross@suse.com>
Juergen Gross writes ("[PATCH 2/2] xenstore: use temporary memory context for firing watches"):
> Use a temporary memory context for memory allocations when firing
> watches. This will avoid leaking memory in case of long living
> connections and/or xenstore entries.
Can you please split out the non-functional argument change to
get_node and get_parent ? This is very hard to review as-is.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-15 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 4:57 [PATCH 0/2] xenstore: fix memory leak of xenstored Juergen Gross
2016-07-15 4:57 ` [PATCH 1/2] xenstore: call each xenstored command function with temporary context Juergen Gross
2016-07-15 16:19 ` Ian Jackson
2016-07-18 6:44 ` Juergen Gross
2016-07-15 4:57 ` [PATCH 2/2] xenstore: use temporary memory context for firing watches Juergen Gross
2016-07-15 16:21 ` Ian Jackson [this message]
2016-07-18 6:44 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22409.3441.478715.747975@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).