From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Subject: [PATCH 2/2] xenstore: add assertion in database dumping code
Date: Wed, 20 Jul 2016 15:24:49 +0100 [thread overview]
Message-ID: <22415.35249.152923.662737@mariner.uk.xensource.com> (raw)
In-Reply-To: <1469024022-6505-3-git-send-email-wei.liu2@citrix.com>
Wei Liu writes ("[PATCH 2/2] xenstore: add assertion in database dumping code"):
> If memfile is NULL, the signal handler won't be installed, hence fopen
> won't dereference NULL. Coverity is not smart enough to figure that out
> unfortunately.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-20 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:13 [PATCH 0/2] Two coverity inspired patches for xenstored Wei Liu
2016-07-20 14:13 ` [PATCH 1/2] xenstore: send error earlier in do_mkdir Wei Liu
2016-07-20 14:25 ` Ian Jackson
2016-07-20 14:13 ` [PATCH 2/2] xenstore: add assertion in database dumping code Wei Liu
2016-07-20 14:24 ` Ian Jackson [this message]
2016-07-20 15:23 ` [PATCH 0/2] Two coverity inspired patches for xenstored Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22415.35249.152923.662737@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).