xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR
Date: Wed, 20 Jul 2016 15:40:56 +0100	[thread overview]
Message-ID: <22415.36216.505200.961794@mariner.uk.xensource.com> (raw)
In-Reply-To: <1468258089-17357-7-git-send-email-wei.liu2@citrix.com>

Wei Liu writes ("[PATCH v2 6/7] libxenstat: honour XEN_RUN_DIR"):
> This is because libxl uses XEN_RUN_DIR to generate the socket path for
> libxenstat while libxenstat itself uses hard-coded path, which is not
> necessarily the same path as XEN_RUN_DIR.  The default configuration
> happened to work because XEN_RUN_DIR defaulted to /var/run/xen, which
> matched the hard-coded path.
> 
> We should make libxenstat use XEN_RUN_DIR so that it works with
> non-default configuration.
> 
> Generate a _paths.h because it is required to make this change work.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

> Backport candidate.

Thanks.  Can you let me know when it's applied to staging ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-20 14:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 17:28 [PATCH v2 0/7] Remove hard-coded /var/run in tools Wei Liu
2016-07-11 17:28 ` [PATCH v2 1/7] xenconsoled: honour XEN_RUN_DIR Wei Liu
2016-07-20 14:41   ` Ian Jackson
2016-07-11 17:28 ` [PATCH v2 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c Wei Liu
2016-07-20 14:41   ` Ian Jackson
2016-07-11 17:28 ` [PATCH v2 3/7] hotplug/FreeBSD: honour XEN_RUN_DIR Wei Liu
2016-07-11 17:28 ` [PATCH v2 4/7] hotplug/NetBSD: " Wei Liu
2016-07-11 17:28 ` [PATCH v2 5/7] hotplug/Linux: " Wei Liu
2016-07-11 17:28 ` [PATCH v2 6/7] libxenstat: " Wei Liu
2016-07-20 14:40   ` Ian Jackson [this message]
2016-07-20 14:48     ` Wei Liu
2016-08-15 10:48       ` Ian Jackson
2016-07-11 17:28 ` [PATCH v2 7/7] oxenstored: " Wei Liu
2016-07-12 16:21 ` [PATCH v2 0/7] Remove hard-coded /var/run in tools Rusty Bird
2016-07-13 14:12   ` Wei Liu
2016-07-20 15:23 ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22415.36216.505200.961794@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).