From: Ian Jackson <ian.jackson@citrix.com>
To: Christian Lindig <christian.lindig@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Tim \(Xen.org\)" <tim@xen.org>,
George Dunlap <George.Dunlap@citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>, David Scott <dave@recoil.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks
Date: Tue, 10 Sep 2019 10:57:11 +0100 [thread overview]
Message-ID: <23927.29559.385471.934984@mariner.uk.xensource.com> (raw)
In-Reply-To: <22C7C052-B208-4BA5-97D2-D17EED80A424@citrix.com>
Christian Lindig writes ("Re: [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks"):
> I understand the desire to automate this but would have kept the
> original proposal for these reasons: changes are rare enough, it is
> obvious how to extend the scheme, the approach stayed well within
> the respective languages. Adding parsers and code generators to the
> build system will make it more difficult to improve it, which at
> least for the OCaml part is very desirable. However, I’m not going
> to object to the patch.
I would love to have this all done in a more "proper" way.
However, in the meantime I do think it is essential to have a check
which actually ties the ocaml code right back to the Xen headers (the
latter being the canonical ABI definition). Indeed the v1 patch in
this very thread had a mismatch between the ocaml and the BUILD_BUG_ON
list, which I only discovered when my checker threw an unexpected
error.
If there are other language bindings which have similar issues we
should check them too.
Ultimately I would prefer it if the Xen ABI were provided in a way
that was useable for automatically generating bindings.
> Acked-by: Christian Lindig <christian.lindig@citrix.com>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-09-10 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 17:12 [Xen-devel] [PATCH 1/3] tools/ocaml: Add missing X86_EMU_VPCI Ian Jackson
2019-09-09 17:12 ` [Xen-devel] [PATCH 2/3] tools/ocaml: Add missing CAP_PV Ian Jackson
2019-09-09 17:12 ` [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks Ian Jackson
2019-09-10 8:29 ` Christian Lindig
2019-09-10 9:57 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23927.29559.385471.934984@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=christian.lindig@citrix.com \
--cc=dave@recoil.org \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).