From: Ian Jackson <ian.jackson@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>, Wei Liu <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] libxlu: Handle += in config files
Date: Tue, 17 Sep 2019 15:57:51 +0100 [thread overview]
Message-ID: <23936.62575.654137.203162@mariner.uk.xensource.com> (raw)
In-Reply-To: <20190813164215.GE1289@perard.uk.xensource.com>
Anthony PERARD writes ("Re: [PATCH] libxlu: Handle += in config files"):
> I wonder if instead of doing += on all strings, we should instead have
> `xl' whitelist the few options where += would make sense. (and at that
> point, it would be easy to add a ' ' where is make sense, like
> "cmdline"s. But then, how to tell users that it can't do "name+='-new'"?
> because xlu would just print a warning, and xl would keep going with
> name="". Try "xl create memory+=42" ;-).
Do we really need to gold-plate it like this ? If someone tries to
append to a string when it doesn't make sense the software will still
do what they ought to have expected. And it doesn't seem like a
likely kind of error.
As for the original patch,
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-09-17 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 14:48 [Xen-devel] [PATCH] libxlu: Handle += in config files Anthony PERARD
2019-08-13 15:06 ` Andrew Cooper
2019-08-13 15:30 ` Anthony PERARD
2019-08-13 15:47 ` Andrew Cooper
2019-08-13 16:42 ` Anthony PERARD
2019-08-16 12:47 ` Wei Liu
2019-08-16 13:09 ` Anthony PERARD
2019-09-17 14:57 ` Ian Jackson [this message]
2019-09-20 11:21 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23936.62575.654137.203162@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).