From: Ian Jackson <ian.jackson@citrix.com>
To: "YOUNG, MICHAEL A." <m.a.young@durham.ac.uk>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Steven Haigh <netwiz@crc.id.au>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry [and 1 more messages]
Date: Mon, 7 Oct 2019 11:01:49 +0100 [thread overview]
Message-ID: <23963.3341.764085.220401@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1910062127110.2837@austen3.home>
Hi. Thanks for the message.
Just one thing I wanted to reply to in your mail:
YOUNG, MICHAEL A. writes ("Re: [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry [and 1 more messages]"):
> On Wed, 11 Sep 2019, Ian Jackson wrote:
> > I find this filename hackery rather unprincipled. I'm not entirely
> > sure I can see a better way, given the way cfg_list is constructed.
> > Can you think of a less hacky approach ?
...
> One option would be to do a fresh search for grubenv in the same places
> we looked for grub.cfg.
>
> Alternatively, it should be possible to do a more precise edit using
> f.rpartition("/").
I don't feel I fully understand the implications, but either of these
seems like they might be good strategies to me. I guess the former
risks finding an unrelated leftover grubenv somewhere which is
probably not desirable.
Anyway, I will leave this to your judgement.
Thanks for the rest of your comments. I'll look forward to a revised
set of patches - thanks.
Regards,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-07 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 23:54 [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry YOUNG, MICHAEL A.
2019-08-14 23:56 ` YOUNG, MICHAEL A.
2019-08-15 6:01 ` Steven Haigh
2019-08-15 7:18 ` M A Young
2019-08-15 19:05 ` YOUNG, MICHAEL A.
2019-08-16 5:25 ` Steven Haigh
2019-08-16 5:37 ` Steven Haigh
2019-08-28 1:35 ` Steven Haigh
2019-09-11 15:57 ` [Xen-devel] [PATCH] read grubenv and set default from saved_entry or next_entry [and 1 more messages] Ian Jackson
2019-10-06 20:54 ` YOUNG, MICHAEL A.
2019-10-07 10:01 ` Ian Jackson [this message]
2019-10-09 8:16 ` Lars Kurth
2019-10-09 10:17 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23963.3341.764085.220401@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=netwiz@crc.id.au \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).