From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAB0C433E0 for ; Tue, 19 May 2020 15:10:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9829B20825 for ; Tue, 19 May 2020 15:10:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9829B20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jb3sm-0007KW-Kk; Tue, 19 May 2020 15:10:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jb3sl-0007KR-To for xen-devel@lists.xenproject.org; Tue, 19 May 2020 15:10:15 +0000 X-Inumbo-ID: d7b92018-99e2-11ea-9887-bc764e2007e4 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d7b92018-99e2-11ea-9887-bc764e2007e4; Tue, 19 May 2020 15:10:15 +0000 (UTC) Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UjjAFFzsPSwk/KYosV2Pe+2/hXCaV4VzkjbANRIO1h0850cizeihSQN+kdf3bixJaJ4XpsCTKL fUCVoLQ+cJQHHY6xPMYe3cKblKhVzn4WOQDovWQ1H+E86w4FKKPa6n1mo5IVcJ8a595fwV5rxu rcpGvFOdro9EFaoPZLugrHrVacZH1NmLykvZ83pBAO5TxMGOf2Gq5MtWzlR12H1a2H4SZoR+Gd 6MhctZ6N7t3A0w/oO089GrJ+yrmxdKdw5s/NXEXdJbS/IYBBDG1KmxDSNycn1jVOMFCVQtCUXI BRw= X-SBRS: 2.7 X-MesageID: 18172747 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,410,1583211600"; d="scan'208";a="18172747" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-ID: <24259.63185.474995.498745@mariner.uk.xensource.com> Date: Tue, 19 May 2020 16:10:09 +0100 To: Jason Andryuk Subject: Re: [PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys In-Reply-To: <20200519015503.115236-8-jandryuk@gmail.com> References: <20200519015503.115236-1-jandryuk@gmail.com> <20200519015503.115236-8-jandryuk@gmail.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Jason Andryuk writes ("[PATCH v7 07/19] libxl: write qemu arguments into separate xenstore keys"): > From: Marek Marczykowski-Górecki > > This allows using arguments with spaces, like -append, without > nominating any special "separator" character. > > Signed-off-by: Marek Marczykowski-Górecki > Reviewed-by: Jason Andryuk > > Write arguments in dm-argv directory instead of overloading mini-os's > dmargs string. > > Make libxl__write_stub_dmargs vary behaviour based on the > is_linux_stubdom flag. Thank you, I like this. Acked-by: Ian Jackson