From: Ian Jackson <ian.jackson@citrix.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Nick Rosbrook <rosbrookn@ainfosec.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/5] gitignore: Ignore golang package directory
Date: Tue, 26 May 2020 17:59:42 +0100 [thread overview]
Message-ID: <24269.19198.604986.160896@mariner.uk.xensource.com> (raw)
In-Reply-To: <A525D330-BCF9-4998-BEC5-425BA6C26CCF@citrix.com>
George Dunlap writes ("Re: [PATCH 5/5] gitignore: Ignore golang package directory"):
> [explanation]
Sounds quite tangled...
> Nick, any opinions?
...
> > Is there not a risk that humans will try to edit it ?
Anyway ISTM that you have definitely considered this so
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
assuming that and Nick convince yourselves you've addressed this
possible issue.
> I suppose someone might. If we decide we want to support older versions of go, we probably want to figure something out there. Options:
>
> 1. Copy the files to a temp directory instead. This is complicated because we have to find a good temp directory, and we’d have to copy them every time, slowing down the incremental build (though not that much).
I don't think that helps much.
> 2. Put a file in the generated directory like “GENERATED_DO_NOT_EDIT”.
>
> 3. Put them in tools/golang/GENERATED_DO_NOT_EDIT/src instead.
Do they not have a header comment saying DO NOT EDIT ?
3 is pretty ugly. I'll leave it up to you whether to bother with 2.
Thanks,
Ian.
next prev parent reply other threads:[~2020-05-26 17:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:12 [PATCH 0/5] Golang build fixes George Dunlap
2020-05-22 16:12 ` [PATCH 1/5] golang: Add a minimum go version to go.mod George Dunlap
2020-05-23 16:29 ` Nick Rosbrook
2020-05-22 16:12 ` [PATCH 2/5] golang: Add a variable for the libxl source directory George Dunlap
2020-05-23 16:32 ` Nick Rosbrook
2020-05-26 13:41 ` Ian Jackson
2020-05-22 16:12 ` [PATCH 3/5] libxl: Generate golang bindings in libxl Makefile George Dunlap
2020-05-23 17:00 ` Nick Rosbrook
2020-05-26 13:53 ` Ian Jackson
2020-05-26 14:56 ` George Dunlap
2020-05-26 16:57 ` Ian Jackson
2020-05-22 16:12 ` [PATCH 4/5] golang/xenlight: Use XEN_PKG_DIR variable rather than open-coding George Dunlap
2020-05-23 16:40 ` Nick Rosbrook
2020-05-23 16:48 ` Nick Rosbrook
2020-05-26 9:31 ` George Dunlap
2020-05-26 15:19 ` Nick Rosbrook
2020-05-26 13:58 ` Ian Jackson
2020-05-22 16:12 ` [PATCH 5/5] gitignore: Ignore golang package directory George Dunlap
2020-05-23 17:03 ` Nick Rosbrook
2020-05-26 13:54 ` Ian Jackson
2020-05-26 15:30 ` George Dunlap
2020-05-26 16:21 ` Nick Rosbrook
2020-05-26 16:33 ` George Dunlap
2020-05-26 16:59 ` Ian Jackson [this message]
2020-05-26 17:07 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24269.19198.604986.160896@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=rosbrookn@ainfosec.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).