From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 042D7C433DF for ; Fri, 12 Jun 2020 14:12:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDF882081A for ; Fri, 12 Jun 2020 14:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF882081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjkPs-0005dx-5Y; Fri, 12 Jun 2020 14:12:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjkPq-0005ds-UE for xen-devel@lists.xenproject.org; Fri, 12 Jun 2020 14:12:18 +0000 X-Inumbo-ID: b90e57b4-acb6-11ea-b5d4-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b90e57b4-acb6-11ea-b5d4-12813bfff9fa; Fri, 12 Jun 2020 14:12:18 +0000 (UTC) Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: HuiODcQvIs84RzWq+XzbI4P0f9gcZjjP2aOhlN4/CUkS4m5l0uJvjxbB2WW6YMhFTlcrDltPMQ zwwmg7/PbAACcr1PvqzBdBynTmC68BdJIoeDsiMaw+kKlg3F1Uycsk31H0HxZKwqMGFaFOUXrq gCJX8poqBk94G0PA5oHi0SF6f0bTyCtIUz8OlY4PHxOJqQiX39TAAfvmKUF9301UTcMsfbaX/5 MwBjgD/LnyOvOXiKeXIw9zW7gQ4+hhPdr8zcpLxoUBoMGsWDqzXKTIWytrCVZgUj3bYQs6XT5Q iAc= X-SBRS: 2.7 X-MesageID: 20147663 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,503,1583211600"; d="scan'208";a="20147663" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-ID: <24291.36156.961284.809662@mariner.uk.xensource.com> Date: Fri, 12 Jun 2020 15:12:12 +0100 To: Andrew Cooper Subject: Re: libxl dirty in tree after libxl build In-Reply-To: <439f3d92-2e18-1868-2b4b-2747973fbe3b@citrix.com> References: <439f3d92-2e18-1868-2b4b-2747973fbe3b@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Andrew Cooper writes ("libxl dirty in tree after libxl build"): > A build of libxl has just dirtied the tree with: > > index 05f7ac74a0..94a4438666 100644 > --- a/tools/libxl/libxlu_disk_l.c > +++ b/tools/libxl/libxlu_disk_l.c > @@ -10,221 +10,11 @@ >  #define FLEX_SCANNER >  #define YY_FLEX_MAJOR_VERSION 2 >  #define YY_FLEX_MINOR_VERSION 6 > -#define YY_FLEX_SUBMINOR_VERSION 4 > +#define YY_FLEX_SUBMINOR_VERSION 1 >  #if YY_FLEX_SUBMINOR_VERSION > 0 >  #define FLEX_BETA >  #endif > > and a whole slew of other changes in the generated code.  It looks like > the version of Flex has just been updated in Jessie. > > Given the flex and bison are strictly required for the libxl build, why > is this temporary file checked in? The point of the exercise is to *not* require them. The reason is that some of our developers have very old development systems which do not support essential flex/bison features. How about we update them to the version from buster ? Ian.