From: Ian Jackson <ian.jackson@citrix.com>
To: Grzegorz Uriasz <gorbak25@gmail.com>
Cc: Wei Liu <wl@xen.org>, "jakub@bartmin.ski" <jakub@bartmin.ski>,
"marmarek@invisiblethingslab.com"
<marmarek@invisiblethingslab.com>,
"j.nowak26@student.uw.edu.pl" <j.nowak26@student.uw.edu.pl>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"contact@puzio.waw.pl" <contact@puzio.waw.pl>
Subject: Re: [PATCH 1/3] tools/libxl: Grant VGA IO port permission for stubdom/target domain
Date: Mon, 15 Jun 2020 12:32:21 +0100 [thread overview]
Message-ID: <24295.23621.756554.824238@mariner.uk.xensource.com> (raw)
In-Reply-To: <87d74a21bde95cfc7c53fad56bf8f0e47724953e.1592171394.git.gorbak25@gmail.com>
Grzegorz Uriasz writes ("[PATCH 1/3] tools/libxl: Grant VGA IO port permission for stubdom/target domain"):
> When qemu is running inside a linux based stubdomain, qemu does not
> have the necessary permissions to map the ioports to the target domain.
> Currently, libxl is granting permissions only for the VGA RAM memory region
> and not passing the required ioports. This patch grants the required
> permission for the necessary vga io ports.
Thanks.
I'm afraid I don't know much about this.
The code looks plausible, although there is a minor breach of official
libxl coding style in the use of `ret' rather than `r' for the xc
return values, and retuerning that value rather than a libxl error
code. I wouldn't regard that as a blocker considering the state of
the surrounding code.
I see from SUPPPORT.md that graphics passthrough seems to be security
supported. Frankly this seems very surprising to me.
Given that, I think we need a review from someone who understood
graphics passthrough.
I think that applies to all 3 of these patches.
Ian.
next prev parent reply other threads:[~2020-06-15 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 22:12 [PATCH 0/3] IGD Passthrough fixes for linux based stubdomains Grzegorz Uriasz
2020-06-14 22:12 ` [PATCH 1/3] tools/libxl: Grant VGA IO port permission for stubdom/target domain Grzegorz Uriasz
2020-06-15 11:17 ` Roger Pau Monné
2020-06-15 11:32 ` Ian Jackson [this message]
2020-06-14 22:12 ` [PATCH 2/3] tools/libxl: Grant permission for mapping opregions to the target domain Grzegorz Uriasz
2020-06-15 12:44 ` Roger Pau Monné
2020-06-14 22:12 ` [PATCH 3/3] tools/libxl: Directly map VBIOS to stubdomain Grzegorz Uriasz
2020-06-15 10:26 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24295.23621.756554.824238@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=contact@puzio.waw.pl \
--cc=gorbak25@gmail.com \
--cc=j.nowak26@student.uw.edu.pl \
--cc=jakub@bartmin.ski \
--cc=marmarek@invisiblethingslab.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).