From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D07C433DF for ; Mon, 15 Jun 2020 14:49:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43130206D7 for ; Mon, 15 Jun 2020 14:49:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43130206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqPw-0003BH-9H; Mon, 15 Jun 2020 14:48:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqPv-0003BC-5k for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 14:48:55 +0000 X-Inumbo-ID: 553512ce-af17-11ea-b803-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 553512ce-af17-11ea-b803-12813bfff9fa; Mon, 15 Jun 2020 14:48:54 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: nv3msrCV/3R+lRdCS9IwrDpR1FfYf6iFAp+/8txCAc3V4Uc9H7cWJ+cE69CP0pqrFFyDQDW3QU J6rHz38DSTPCKPkg+4Lt6F1+LUfTzeIbL4/UpgjsUJugzqSWkymvVV8yALgCwNJ2qsYZe7Fxg7 GhvCsbpMpzw/r1xg+qUZsj+2UsyTD9i5uknjqPh03gMyJ8CfeN0wibg6bHwNXArrLoP7Sd3Chu Z4Hvhziqev/AT7vtdwBpyLspjdP0xCGkJlg+KQufptDA9AZczqlRHtrU7wnKt9Z8pucbXz4Sek Eds= X-SBRS: 2.7 X-MesageID: 20082872 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,514,1583211600"; d="scan'208";a="20082872" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24295.35408.178162.309295@mariner.uk.xensource.com> Date: Mon, 15 Jun 2020 15:48:48 +0100 To: Andrew Cooper Subject: Re: [PATCH for-4.13] tools/libxl: Fix memory leak in libxl_cpuid_set() In-Reply-To: <20200612173227.4103-1-andrew.cooper3@citrix.com> References: <20200612173227.4103-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Andrew Cooper writes ("[PATCH for-4.13] tools/libxl: Fix memory leak in libxl_cpuid_set()"): > xc_cpuid_set() returns allocated memory via cpuid_res, which libxl needs to > free() seeing as it discards the results. > > This is logically a backport of c/s b91825f628 "tools/libxc: Drop > config_transformed parameter from xc_cpuid_set()" but rewritten as one caller > of xc_cpuid_set() does use returned values. > > Signed-off-by: Andrew Cooper > --- > CC: Ian Jackson > > Applicable for 4.13 and older. Thanks. I have committed this to 4.13 and 4.12. 4.12 is no longer supported for bugfixes like this one. > I'm not going to touch the Ocaml bindings - they're wrong in multiple ways > including this memory leak, and we deleted them in 4.14 because they were > totally unused. That makes sense to me. Ian.