From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEDFC433E0 for ; Mon, 15 Jun 2020 14:51:49 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 661D720644 for ; Mon, 15 Jun 2020 14:51:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 661D720644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqSa-00041W-5R; Mon, 15 Jun 2020 14:51:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkqSY-00041O-NS for xen-devel@lists.xenproject.org; Mon, 15 Jun 2020 14:51:38 +0000 X-Inumbo-ID: b64e625e-af17-11ea-b805-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b64e625e-af17-11ea-b805-12813bfff9fa; Mon, 15 Jun 2020 14:51:37 +0000 (UTC) Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: f73RR2H5j2vDOwXb/RJuXFDuihdqf6B5sew/Fa3YXkJOzvggFGXRB8n/5vnMx/B7zgRdUBr5hP t2L/p8JpatIT75SNug2hBVfvZ2c8R7nd1yJCPtgSRaXeAaQwTnwCPyjr01v94WiPx9tEvBcdzs IQZ/ZzR7NYeuSPU0oKERpcdNWKwMPYkNopnYJ3OJUtchGTQITdSC4R3N5HrhUsAAQUr8N8xEcR GdgUxAfbM7XiOeFAkNfB4bex4INi2uXyiQBOLNZjHxaaR0o08fgkNtYxSaDNvmEisAFiboWf9S CpA= X-SBRS: 2.7 X-MesageID: 20083199 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,514,1583211600"; d="scan'208";a="20083199" From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <24295.35571.422130.264071@mariner.uk.xensource.com> Date: Mon, 15 Jun 2020 15:51:31 +0100 To: Andrew Cooper Subject: Re: [PATCH 1/9] tools/libx[cl]: Introduce struct xc_xend_cpuid for xc_cpuid_set() In-Reply-To: <20200615141532.1927-2-andrew.cooper3@citrix.com> References: <20200615141532.1927-1-andrew.cooper3@citrix.com> <20200615141532.1927-2-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Paul Durrant , Jan Beulich , Wei Liu , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Andrew Cooper writes ("[PATCH 1/9] tools/libx[cl]: Introduce struct xc_xend_cpuid for xc_cpuid_set()"): > In order to combine the functionality of xc_cpuid_set() with > xc_cpuid_apply_policy(), arrange to pass the data in a single contained > struct, rather than two arrays. > > libxl__cpuid_policy is the ideal structure to use, but that would introduce a > reverse dependency between libxc and libxl. Introduce xc_xend_cpuid (with a > transparent union to provide more useful names for the inputs), and use this > structure in libxl. > > The public API has libxl_cpuid_policy as an opaque type referencing > libxl__cpuid_policy. Drop the inappropriate comment about its internals, and > use xc_xend_cpuid as a differently named opaque backing object. Users of both > libxl and libxc are not permitted to look at the internals. > > No change in behaviour. > Acked-by: Ian Jackson