From: Ian Jackson <ian.jackson@citrix.com>
To: "paul@xen.org" <paul@xen.org>
Cc: Igor Druzhinin <igor.druzhinin@citrix.com>,
"xadimgnik@gmail.com" <xadimgnik@gmail.com>,
"wl@xen.org" <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update
Date: Thu, 18 Jun 2020 16:44:41 +0100 [thread overview]
Message-ID: <24299.35817.486533.42273@mariner.uk.xensource.com> (raw)
In-Reply-To: <005b01d64482$da189650$8e49c2f0$@xen.org>
Paul Durrant writes ("RE: [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update"):
> > -----Original Message-----
> > From: Igor Druzhinin <igor.druzhinin@citrix.com>
> > Sent: 17 June 2020 03:19
> > To: xen-devel@lists.xenproject.org
> > Cc: ian.jackson@eu.citrix.com; wl@xen.org; xadimgnik@gmail.com; Igor Druzhinin
> > <igor.druzhinin@citrix.com>
> > Subject: [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update
> >
> > Otherwise it's difficult to know if operation failed inside the automation.
> >
> > While at it, also switch to returning 1 and 2 instead of errno to avoid
> > incompatibilies between errno and special exit code numbers.
> >
> > Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Thanks, this looks good to me.
> Reviewed-by: Paul Durrant <paul@xen.org>
> Release-acked-by: Paul Durrant <paul@xen.org>
Reviewed-by: Ian Jackson <ian.jackson@eu.citrix.com>
I will commit this in a moment.
Ian.
prev parent reply other threads:[~2020-06-18 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 2:19 [PATCH for-4.14 v3] tools/xen-ucode: return correct exit code on failed microcode update Igor Druzhinin
2020-06-17 8:39 ` Paul Durrant
2020-06-18 15:44 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24299.35817.486533.42273@mariner.uk.xensource.com \
--to=ian.jackson@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xadimgnik@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).