From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3B4C433DB for ; Tue, 16 Feb 2021 16:26:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1F1B64D79 for ; Tue, 16 Feb 2021 16:26:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1F1B64D79 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.85937.160868 (Exim 4.92) (envelope-from ) id 1lC3BH-0002w2-FX; Tue, 16 Feb 2021 16:26:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 85937.160868; Tue, 16 Feb 2021 16:26:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3BH-0002vu-Bm; Tue, 16 Feb 2021 16:26:31 +0000 Received: by outflank-mailman (input) for mailman id 85937; Tue, 16 Feb 2021 16:26:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3BG-0002vo-CO for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:26:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lC3BG-0004RS-BW for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:26:30 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lC3BG-0005aR-Ak for xen-devel@lists.xenproject.org; Tue, 16 Feb 2021 16:26:30 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lC3BC-0000oW-Sv; Tue, 16 Feb 2021 16:26:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=xujiUnVe7uienQ0IKm30itwOU1hhpKUE444zbfdEHH8=; b=3d8U3E7xJakLqYq42wJXXrwPbn OzU+sglZ/SeEZDYl65vfgAn8w4Et2XiqmU+muaZmyR/PZtDAcTpnvszT10Vtpv1h5Xb+g3lUPwokG y7iGdrFT7I2Lo3pYmJ2KWHnZD0mugbidTtIY2m94VbdRxO1KU0tfjqGbRi/f6xpClEXQ=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <24619.62002.658637.648192@mariner.uk.xensource.com> Date: Tue, 16 Feb 2021 16:26:26 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu , Anthony PERARD Subject: Re: [PATCH 05/10] tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs() In-Reply-To: <20210212153953.4582-6-andrew.cooper3@citrix.com> References: <20210212153953.4582-1-andrew.cooper3@citrix.com> <20210212153953.4582-6-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 05/10] tools/libxl: Fix uninitialised variable in libxl__write_stub_dmargs()"): > Various version of gcc, when compiling with -Og, complain: > > libxl_dm.c: In function ‘libxl__write_stub_dmargs’: > libxl_dm.c:2166:16: error: ‘dmargs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > rc = libxl__xs_write_checked(gc, t, path, dmargs); > ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reviewed-by: Ian Jackson