From: Ian Jackson <iwj@xenproject.org>
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, jbeulich@suse.com,
sstabellini@kernel.org, ash.j.wilding@gmail.com,
Julien Grall <jgrall@amazon.com>,
George Dunlap <george.dunlap@citrix.com>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH for-4.15] xen/sched: Add missing memory barrier in vcpu_block()
Date: Mon, 22 Feb 2021 11:11:21 +0000 [thread overview]
Message-ID: <24627.37209.655443.911873@mariner.uk.xensource.com> (raw)
In-Reply-To: <20210220194701.24202-1-julien@xen.org>
Julien Grall writes ("[PATCH for-4.15] xen/sched: Add missing memory barrier in vcpu_block()"):
> From: Julien Grall <jgrall@amazon.com>
>
> The comment in vcpu_block() states that the events should be checked
> /after/ blocking to avoids wakeup waiting race. However, from a generic
> perspective, set_bit() doesn't prevent re-ordering. So the following
> could happen:
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
next prev parent reply other threads:[~2021-02-22 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 19:47 [PATCH for-4.15] xen/sched: Add missing memory barrier in vcpu_block() Julien Grall
2021-02-22 11:11 ` Ian Jackson [this message]
2021-02-22 14:26 ` Jan Beulich
2021-02-22 20:09 ` Stefano Stabellini
2021-02-22 20:12 ` Julien Grall
2021-02-23 1:22 ` Stefano Stabellini
2021-02-23 7:00 ` Jan Beulich
2021-02-23 9:04 ` Julien Grall
2021-02-23 8:45 ` Dario Faggioli
2021-02-23 13:24 ` Ash Wilding
2021-02-25 14:01 ` Julien Grall
2021-02-25 21:35 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24627.37209.655443.911873@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=ash.j.wilding@gmail.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).