From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F8DC433E0 for ; Wed, 3 Mar 2021 16:10:20 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D5F364EF0 for ; Wed, 3 Mar 2021 16:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D5F364EF0 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.92900.175163 (Exim 4.92) (envelope-from ) id 1lHU4h-0007iF-Bs; Wed, 03 Mar 2021 16:10:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 92900.175163; Wed, 03 Mar 2021 16:10:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4h-0007i8-8o; Wed, 03 Mar 2021 16:10:11 +0000 Received: by outflank-mailman (input) for mailman id 92900; Wed, 03 Mar 2021 16:10:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4g-0007i3-DO for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHU4g-00041a-CZ for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHU4g-0005fT-Bk for xen-devel@lists.xenproject.org; Wed, 03 Mar 2021 16:10:10 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHU4d-0002Ve-1T; Wed, 03 Mar 2021 16:10:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=DVLSgcK5zaBMulebW4DcYpNeqdnCO5So83EVAKndzdQ=; b=k3uk8JwIhG95qcDjQZwzIQl+sc HsTBzByX4fsn4C8sIyktNWb7ilro/HoIUToCjuNZogDoWtUuwlh/WytpHAkknR6YMeC10pLDVM4Tt +EauS0byOp1dxdINMVdPMSvPnUlYrrxyo/7iwNdcx1hJBFr2tFYFdWKK9AKIiIxXCkNU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24639.46302.755089.845426@mariner.uk.xensource.com> Date: Wed, 3 Mar 2021 16:10:06 +0000 To: Norbert Manthey Cc: , Juergen Gross , Wei Liu , Julien Grall , Michael Kurth Subject: Re: [PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error In-Reply-To: <20210226144144.9252-5-nmanthey@amazon.de> References: <20210226144144.9252-1-nmanthey@amazon.de> <20210226144144.9252-5-nmanthey@amazon.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Norbert Manthey writes ("[PATCH XENSTORE v1 04/10] xenstore_client: handle memory on error"): > In case a command fails, also free the memory. As this is for the CLI > client, currently the leaked memory is freed right after receiving the > error, as the application terminates next. > > Similarly, if the allocation fails, do not use the NULL pointer > afterwards, but instead error out. I think this is not for 4.15. Thanks, Ian.