From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B94C433DB for ; Thu, 4 Mar 2021 14:15:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCE7464EEC for ; Thu, 4 Mar 2021 14:15:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCE7464EEC Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.93273.176071 (Exim 4.92) (envelope-from ) id 1lHokk-00056O-5a; Thu, 04 Mar 2021 14:14:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93273.176071; Thu, 04 Mar 2021 14:14:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHokk-00056H-1X; Thu, 04 Mar 2021 14:14:58 +0000 Received: by outflank-mailman (input) for mailman id 93273; Thu, 04 Mar 2021 14:14:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoki-00056C-95 for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lHoki-0004Me-6B for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lHoki-0002u4-3C for xen-devel@lists.xenproject.org; Thu, 04 Mar 2021 14:14:56 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lHoke-0005Q1-P0; Thu, 04 Mar 2021 14:14:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ilTSBOQcaJfKfwwLDwvDkIwXAN/2O/+CIOpiTgfqddc=; b=NCwx4WE+loLVX4C9Q15Vqrf9x0 HJx7vtf+2sQ6c0V/qTTkop/NNUmP3PgDwuK/7lun5HVEccsCsmTv5SoDcyx5uxlskRQsERHGEsCBi 3yBhxFqjB5e0HHQPcsGNBgy66Nt66wE322ej+MBt+dcjqBszTe6LSN84vCVOC7BIEVZU=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24640.60252.467968.279717@mariner.uk.xensource.com> Date: Thu, 4 Mar 2021 14:14:52 +0000 To: Andrew Cooper Cc: Xen-devel , Wei Liu Subject: Re: [PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard In-Reply-To: <20210304130319.10719-1-andrew.cooper3@citrix.com> References: <20210304130319.10719-1-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH for-4.15] tools/libxendevicemodel: Strip __XEN_TOOLS__ header guard"): > This is inappropriate for the header file of a standalone library with stable > API and ABI. > > Signed-off-by: Andrew Cooper Reviewed-by: Ian Jackson