From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE3EC433DB for ; Fri, 5 Mar 2021 13:26:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C29C64FDD for ; Fri, 5 Mar 2021 13:26:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C29C64FDD Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.93698.176798 (Exim 4.92) (envelope-from ) id 1lIATB-0006pe-S7; Fri, 05 Mar 2021 13:26:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 93698.176798; Fri, 05 Mar 2021 13:26:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIATB-0006pX-P7; Fri, 05 Mar 2021 13:26:17 +0000 Received: by outflank-mailman (input) for mailman id 93698; Fri, 05 Mar 2021 13:26:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0006pJ-M7 for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0006jW-LO for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1lIAT9-0001xq-KZ for xen-devel@lists.xenproject.org; Fri, 05 Mar 2021 13:26:15 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1lIAT5-0008PD-9B; Fri, 05 Mar 2021 13:26:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=UCfUwpWMCIJsgTt0fuDfo/59MmUPhJuOtuM86PxmU5Q=; b=mi7Lzapb18Y5L1VSfeH5bTEwUb regfP/J64HXhFFQR6RIG5A4U+wDUUPj/2nfONpAOD1Rg2T4AAQMytu0r7vfrcuPvRLbxriLT5n3aU G7SHVGdRNfc5lK7akQ/u/4UhgYmT8R3L8SYS0WxOAbiajoUbEqaJ/THvEI3glNIINbyg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24642.12659.29219.954222@mariner.uk.xensource.com> Date: Fri, 5 Mar 2021 13:26:11 +0000 To: Andrew Cooper Cc: Xen-devel , Jan Beulich , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Paul Durrant Subject: Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API In-Reply-To: <20210305124949.6719-3-andrew.cooper3@citrix.com> References: <20210305124949.6719-1-andrew.cooper3@citrix.com> <20210305124949.6719-3-andrew.cooper3@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Andrew Cooper writes ("[PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API"): > Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library. > > That change actually broke the build with: > > include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t' > ioservid_t *id); > ^ > > as libxendevicemodel.h now uses a type it can't see a typedef for. However, > nothing noticed because the header.chk logic is also broken (fixed > subsequently). > > Strip the guard from the public header, and remove compensation from > devicemodel's private.h Release-Acked-by: Ian Jackson