From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2BCC4338F for ; Thu, 19 Aug 2021 16:43:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A769D610A5 for ; Thu, 19 Aug 2021 16:43:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A769D610A5 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.168951.308541 (Exim 4.92) (envelope-from ) id 1mGl8P-0008P0-IN; Thu, 19 Aug 2021 16:43:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 168951.308541; Thu, 19 Aug 2021 16:43:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGl8P-0008Ot-E2; Thu, 19 Aug 2021 16:43:17 +0000 Received: by outflank-mailman (input) for mailman id 168951; Thu, 19 Aug 2021 16:43:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGl8O-0008Ok-3J for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 16:43:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mGl8O-0004RQ-2F for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 16:43:16 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mGl8O-0005m7-1E for xen-devel@lists.xenproject.org; Thu, 19 Aug 2021 16:43:16 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mGl8J-0002Iy-AO; Thu, 19 Aug 2021 17:43:11 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=U/JedYRgAVFfXGAzwBX4nxL0YLb67ajOy+X9NzwzsQc=; b=MsgO8BBvccqE9gTXTBrcOyUHmn rODZzoQQoUjp3mxWQh1dSRzr78C+ROp2PPLdghMcdrQFvcqwCDQ+m7myiPhYRd/CnC6PN+nSgYFx+ 1kzxoMCt04XWi4HtLGO/11XSBYv++1PYtMzAuNoBam7q+mvc6FZoAxKxMjL2GTxaaJ2U=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24862.35359.95257.223452@mariner.uk.xensource.com> Date: Thu, 19 Aug 2021 17:43:11 +0100 To: Andrew Cooper , Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Ian Jackson , George Dunlap , Stefano Stabellini , Wei Liu , Anthony Perard , Julien Grall Subject: Re: preparations for 4.15.1 and 4.13.4 [and 1 more messages] In-Reply-To: <48cc22b9-6d0a-2cfc-ce34-6aabeb84b160@suse.com>, <8324f959-924b-d196-149d-2fdad95da8fa@citrix.com> References: <48cc22b9-6d0a-2cfc-ce34-6aabeb84b160@suse.com> <8324f959-924b-d196-149d-2fdad95da8fa@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("preparations for 4.15.1 and 4.13.4"): > Ian: I did take the liberty to backport Anthony's > > 5d3e4ebb5c71 libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype Thanks. > Beyond this I'd like the following to be considered: > > 6409210a5f51 libxencall: osdep_hypercall() should return long > bef64f2c0019 libxencall: introduce variant of xencall2() returning long > 01a2d001dea2 libxencall: Bump SONAME following new functionality > 6f02d1ea4a10 libxc: use multicall for memory-op on Linux (and Solaris) I agree these are needed. Don't we need these, or something like them in 4.14 and earlier too ? > If those are to be taken (which means in particular if the question of > the .so versioning can be properly sorted), > > 198a2bc6f149 x86/HVM: wire up multicalls > > is going to be required as a prereq. I have backports of all of the > above ready (so I could put them in if you tell me to), but for > 01a2d001dea2 only in its straightforward but simplistic form, which I'm > not sure is the right thing to do. So, I have queued 198a2bc6f149 too. As for the ABI: 01a2d001dea2 introduces VERS_1.3 with xencall2L. I think backporting it to 4.15 means declaring that that is precisely what VERS_1.3 is, and that any future changes must be in VERS_1.4. I checked that after the backport of 198a2bc6f149, the two files defining VERS_1.3 are the same. Well, they are different because of 7ffbed8681a0 libxencall: drop bogus mentioning of xencall6() which is fine, since that symbol didn't exist in any version. So I propose to bump xencall to 1.4 in staging, to make sure we don't break the ABI for 1.3 by mistake. Andrew Cooper writes ("Re: preparations for 4.15.1 and 4.13.4"): > We can backport changes in SONAME safely so long as: > > 1) We declare VERS_1.2 to be fixed and released.  This means that we > bump to 1.3 for the next change, even if it is ahead of Xen 4.16 being > release, and > > 2) *All* ABI changes up to VERS_1.2 are backported. I think this is what I am doing, except that I think Andy wrote "1.2" instead of "1.3". "1.2" is currently in staging-4.15, without my queued series. > The ABI called VERS_1.2 must be identical on all older branches to avoid > binary problems when rebuilding a package against old-xen+updates, and > then updating to a newer Xen. Indeed. But that is less relevant than the fact that this must also be true for VERS_1.3 which is what we are introducing to 4.15 here :-). Andy, I usually agree with you on ABI matters. I think I am doing what you mean. Please correct me if I have misunderstood you. If what I hnve done is wrong, we should revert and/or fix it quickly on staging-4.15. (I'll ping you in IRC when I have pushed my queue to staging-4.15.) Ian.