From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1218C433EF for ; Fri, 15 Oct 2021 12:13:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B272E61090 for ; Fri, 15 Oct 2021 12:13:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B272E61090 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.210417.367276 (Exim 4.92) (envelope-from ) id 1mbM5G-0001o0-So; Fri, 15 Oct 2021 12:13:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 210417.367276; Fri, 15 Oct 2021 12:13:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mbM5G-0001nr-PU; Fri, 15 Oct 2021 12:13:10 +0000 Received: by outflank-mailman (input) for mailman id 210417; Fri, 15 Oct 2021 12:13:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mbM5F-0001nl-UO for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mbM5F-0003a4-Ta for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mbM5F-0006Wi-SL for xen-devel@lists.xenproject.org; Fri, 15 Oct 2021 12:13:09 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mbM59-0005dj-2x; Fri, 15 Oct 2021 13:13:03 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=5DosDQ0jMg17JaXbVmtbhh3Os9IDrkBEW2QKyuFFuEM=; b=cgf0HQP7jjn1UUnzEmu7k91rnr tvrTNQMTozxE1wVQ/5gPBRPIaBg3Ud56xBLAVcO0w6knvOF3J5ty1vEDN0iNjre67ATRuresOZwK1 05Dm0cET5zM9F5Ylh2hwR54thTqG7LrDRArZUcxHQ7O3oN5+nU70GHJN4Hzvh62Fh67s=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24937.28750.781635.971114@mariner.uk.xensource.com> Date: Fri, 15 Oct 2021 13:13:02 +0100 To: Michal Orzel Cc: Julien Grall , Bertrand Marquis , xen-devel@lists.xenproject.org, Rahul Singh , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Volodymyr Babchuk , Andre Przywara Subject: Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages] In-Reply-To: <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com> References: <7bdac405-a889-15e1-be19-5876f7253855@xen.org> <24926.53690.621007.507249@mariner.uk.xensource.com> <294BE20A-7E45-405C-BC19-C292295E85E3@arm.com> <24927.7235.736221.270358@mariner.uk.xensource.com> <8A04B9B2-E816-425E-BF1B-5A8B89F8836C@arm.com> <24936.28385.679884.535704@mariner.uk.xensource.com> <6f82141c-8a0b-1e30-a996-223f7c0c508d@xen.org> <24937.20922.73382.850023@mariner.uk.xensource.com> <56490119-6040-9ab1-aab7-e43975cbb80d@arm.com> <24937.27149.222087.933297@mariner.uk.xensource.com> <6e29d836-918c-3b15-7608-342b2e4f8475@arm.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]"): > On 15.10.2021 13:46, Ian Jackson wrote: > > Maybe something like > > > > // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to > > // decide whether to enable vpci, rather than using c_info->passthrough. > > // This will be insufficient if and when ARM does PCI hotplug. > > Well we are not enabling vpci. We are creating a DT node for it. > So either I will write: > /* > * Note: libxl_arm directly examines num_pcidevs to decide whether > * to create a vPCI DT node, rather than using c_info->passthrough. > * This will be insufficient if and when ARM does PCI hotplug. > */ That sounds good to me. Thank you for correcting me :-). Ian.