Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
@ 2019-05-28 22:48 Stefano Stabellini
  2019-05-28 22:48 ` [Xen-devel] " Stefano Stabellini
  2019-05-28 23:50 ` Boris Ostrovsky
  0 siblings, 2 replies; 16+ messages in thread
From: Stefano Stabellini @ 2019-05-28 22:48 UTC (permalink / raw)
  To: konrad.wilk, boris.ostrovsky, jgross; +Cc: xen-devel, Julien.Grall, sstabellini

From: Stefano Stabellini <stefanos@xilinx.com>

On arm64 swiotlb is often (not always) already initialized by mem_init.
We don't want to initialize it twice, which would trigger a second
memory allocation. Moreover, the second memory pool is typically made of
high pages and ends up replacing the original memory pool of low pages.
As a side effect of this change, it is possible to have low pages in
swiotlb-xen on arm64.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
---
Changes in v2:
- improve commit message
- don't add nested ifs

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 877baf2..8a3cdd1 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -211,6 +211,15 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 retry:
 	bytes = xen_set_nslabs(xen_io_tlb_nslabs);
 	order = get_order(xen_io_tlb_nslabs << IO_TLB_SHIFT);
+
+	/*
+	 * IO TLB memory already allocated. Just use it.
+	 */
+	if (io_tlb_start != 0) {
+		xen_io_tlb_start = phys_to_virt(io_tlb_start);
+		goto end;
+	}
+
 	/*
 	 * Get IO TLB memory from any location.
 	 */
@@ -240,7 +249,6 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 		m_ret = XEN_SWIOTLB_ENOMEM;
 		goto error;
 	}
-	xen_io_tlb_end = xen_io_tlb_start + bytes;
 	/*
 	 * And replace that memory with pages under 4GB.
 	 */
@@ -267,6 +275,8 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 	} else
 		rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs);
 
+end:
+	xen_io_tlb_end = xen_io_tlb_start + bytes;
 	if (!rc)
 		swiotlb_set_max_segment(PAGE_SIZE);
 
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-05-28 22:48 [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64 Stefano Stabellini
@ 2019-05-28 22:48 ` " Stefano Stabellini
  2019-05-28 23:50 ` Boris Ostrovsky
  1 sibling, 0 replies; 16+ messages in thread
From: Stefano Stabellini @ 2019-05-28 22:48 UTC (permalink / raw)
  To: konrad.wilk, boris.ostrovsky, jgross; +Cc: xen-devel, Julien.Grall, sstabellini

From: Stefano Stabellini <stefanos@xilinx.com>

On arm64 swiotlb is often (not always) already initialized by mem_init.
We don't want to initialize it twice, which would trigger a second
memory allocation. Moreover, the second memory pool is typically made of
high pages and ends up replacing the original memory pool of low pages.
As a side effect of this change, it is possible to have low pages in
swiotlb-xen on arm64.

Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
---
Changes in v2:
- improve commit message
- don't add nested ifs

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 877baf2..8a3cdd1 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -211,6 +211,15 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 retry:
 	bytes = xen_set_nslabs(xen_io_tlb_nslabs);
 	order = get_order(xen_io_tlb_nslabs << IO_TLB_SHIFT);
+
+	/*
+	 * IO TLB memory already allocated. Just use it.
+	 */
+	if (io_tlb_start != 0) {
+		xen_io_tlb_start = phys_to_virt(io_tlb_start);
+		goto end;
+	}
+
 	/*
 	 * Get IO TLB memory from any location.
 	 */
@@ -240,7 +249,6 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 		m_ret = XEN_SWIOTLB_ENOMEM;
 		goto error;
 	}
-	xen_io_tlb_end = xen_io_tlb_start + bytes;
 	/*
 	 * And replace that memory with pages under 4GB.
 	 */
@@ -267,6 +275,8 @@ int __ref xen_swiotlb_init(int verbose, bool early)
 	} else
 		rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs);
 
+end:
+	xen_io_tlb_end = xen_io_tlb_start + bytes;
 	if (!rc)
 		swiotlb_set_max_segment(PAGE_SIZE);
 
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-05-28 22:48 [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64 Stefano Stabellini
  2019-05-28 22:48 ` [Xen-devel] " Stefano Stabellini
@ 2019-05-28 23:50 ` Boris Ostrovsky
  2019-05-28 23:50   ` [Xen-devel] " Boris Ostrovsky
  2019-06-03 18:25   ` Stefano Stabellini
  1 sibling, 2 replies; 16+ messages in thread
From: Boris Ostrovsky @ 2019-05-28 23:50 UTC (permalink / raw)
  To: Stefano Stabellini, konrad.wilk, jgross; +Cc: xen-devel, Julien.Grall

On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefanos@xilinx.com>
>
> On arm64 swiotlb is often (not always) already initialized by mem_init.
> We don't want to initialize it twice, which would trigger a second
> memory allocation. Moreover, the second memory pool is typically made of
> high pages and ends up replacing the original memory pool of low pages.
> As a side effect of this change, it is possible to have low pages in
> swiotlb-xen on arm64.
>
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>

Has this been tested on x86?

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-05-28 23:50 ` Boris Ostrovsky
@ 2019-05-28 23:50   ` " Boris Ostrovsky
  2019-06-03 18:25   ` Stefano Stabellini
  1 sibling, 0 replies; 16+ messages in thread
From: Boris Ostrovsky @ 2019-05-28 23:50 UTC (permalink / raw)
  To: Stefano Stabellini, konrad.wilk, jgross; +Cc: xen-devel, Julien.Grall

On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefanos@xilinx.com>
>
> On arm64 swiotlb is often (not always) already initialized by mem_init.
> We don't want to initialize it twice, which would trigger a second
> memory allocation. Moreover, the second memory pool is typically made of
> high pages and ends up replacing the original memory pool of low pages.
> As a side effect of this change, it is possible to have low pages in
> swiotlb-xen on arm64.
>
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>

Has this been tested on x86?

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-05-28 23:50 ` Boris Ostrovsky
  2019-05-28 23:50   ` [Xen-devel] " Boris Ostrovsky
@ 2019-06-03 18:25   ` Stefano Stabellini
  2019-06-03 18:25     ` [Xen-devel] " Stefano Stabellini
  2019-06-03 23:16     ` Boris Ostrovsky
  1 sibling, 2 replies; 16+ messages in thread
From: Stefano Stabellini @ 2019-06-03 18:25 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: jgross, xen-devel, Julien.Grall, Stefano Stabellini, konrad.wilk

On Tue, 28 May 2019, Boris Ostrovsky wrote:
> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefanos@xilinx.com>
> >
> > On arm64 swiotlb is often (not always) already initialized by mem_init.
> > We don't want to initialize it twice, which would trigger a second
> > memory allocation. Moreover, the second memory pool is typically made of
> > high pages and ends up replacing the original memory pool of low pages.
> > As a side effect of this change, it is possible to have low pages in
> > swiotlb-xen on arm64.
> >
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> 
> Has this been tested on x86?

Yes, I managed to test it using QEMU. There are no effects on x86, as
the check io_tlb_start != 0 returns false.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-03 18:25   ` Stefano Stabellini
@ 2019-06-03 18:25     ` " Stefano Stabellini
  2019-06-03 23:16     ` Boris Ostrovsky
  1 sibling, 0 replies; 16+ messages in thread
From: Stefano Stabellini @ 2019-06-03 18:25 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: jgross, xen-devel, Julien.Grall, Stefano Stabellini, konrad.wilk

On Tue, 28 May 2019, Boris Ostrovsky wrote:
> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> > From: Stefano Stabellini <stefanos@xilinx.com>
> >
> > On arm64 swiotlb is often (not always) already initialized by mem_init.
> > We don't want to initialize it twice, which would trigger a second
> > memory allocation. Moreover, the second memory pool is typically made of
> > high pages and ends up replacing the original memory pool of low pages.
> > As a side effect of this change, it is possible to have low pages in
> > swiotlb-xen on arm64.
> >
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> 
> Has this been tested on x86?

Yes, I managed to test it using QEMU. There are no effects on x86, as
the check io_tlb_start != 0 returns false.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-03 18:25   ` Stefano Stabellini
  2019-06-03 18:25     ` [Xen-devel] " Stefano Stabellini
@ 2019-06-03 23:16     ` Boris Ostrovsky
  2019-06-03 23:16       ` [Xen-devel] " Boris Ostrovsky
  2019-06-04 16:51       ` Stefano Stabellini
  1 sibling, 2 replies; 16+ messages in thread
From: Boris Ostrovsky @ 2019-06-03 23:16 UTC (permalink / raw)
  To: Stefano Stabellini; +Cc: jgross, xen-devel, Julien.Grall, konrad.wilk

On 6/3/19 2:25 PM, Stefano Stabellini wrote:
> On Tue, 28 May 2019, Boris Ostrovsky wrote:
>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
>>> From: Stefano Stabellini <stefanos@xilinx.com>
>>>
>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
>>> We don't want to initialize it twice, which would trigger a second
>>> memory allocation. Moreover, the second memory pool is typically made of
>>> high pages and ends up replacing the original memory pool of low pages.
>>> As a side effect of this change, it is possible to have low pages in
>>> swiotlb-xen on arm64.
>>>
>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>> Has this been tested on x86?
> Yes, I managed to test it using QEMU. There are no effects on x86, as
> the check io_tlb_start != 0 returns false.

I wonder though whether this is always the case.  When we are called
from pci_xen_swiotlb_init_late() for example.


-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-03 23:16     ` Boris Ostrovsky
@ 2019-06-03 23:16       ` " Boris Ostrovsky
  2019-06-04 16:51       ` Stefano Stabellini
  1 sibling, 0 replies; 16+ messages in thread
From: Boris Ostrovsky @ 2019-06-03 23:16 UTC (permalink / raw)
  To: Stefano Stabellini; +Cc: jgross, xen-devel, Julien.Grall, konrad.wilk

On 6/3/19 2:25 PM, Stefano Stabellini wrote:
> On Tue, 28 May 2019, Boris Ostrovsky wrote:
>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
>>> From: Stefano Stabellini <stefanos@xilinx.com>
>>>
>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
>>> We don't want to initialize it twice, which would trigger a second
>>> memory allocation. Moreover, the second memory pool is typically made of
>>> high pages and ends up replacing the original memory pool of low pages.
>>> As a side effect of this change, it is possible to have low pages in
>>> swiotlb-xen on arm64.
>>>
>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>> Has this been tested on x86?
> Yes, I managed to test it using QEMU. There are no effects on x86, as
> the check io_tlb_start != 0 returns false.

I wonder though whether this is always the case.  When we are called
from pci_xen_swiotlb_init_late() for example.


-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-03 23:16     ` Boris Ostrovsky
  2019-06-03 23:16       ` [Xen-devel] " Boris Ostrovsky
@ 2019-06-04 16:51       ` Stefano Stabellini
  2019-06-04 19:41         ` Boris Ostrovsky
  1 sibling, 1 reply; 16+ messages in thread
From: Stefano Stabellini @ 2019-06-04 16:51 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: jgross, xen-devel, Julien.Grall, Stefano Stabellini, konrad.wilk

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
> On 6/3/19 2:25 PM, Stefano Stabellini wrote:
> > On Tue, 28 May 2019, Boris Ostrovsky wrote:
> >> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> >>> From: Stefano Stabellini <stefanos@xilinx.com>
> >>>
> >>> On arm64 swiotlb is often (not always) already initialized by mem_init.
> >>> We don't want to initialize it twice, which would trigger a second
> >>> memory allocation. Moreover, the second memory pool is typically made of
> >>> high pages and ends up replacing the original memory pool of low pages.
> >>> As a side effect of this change, it is possible to have low pages in
> >>> swiotlb-xen on arm64.
> >>>
> >>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> >> Has this been tested on x86?
> > Yes, I managed to test it using QEMU. There are no effects on x86, as
> > the check io_tlb_start != 0 returns false.
> 
> I wonder though whether this is always the case.  When we are called
> from pci_xen_swiotlb_init_late() for example.

In that case, pci_xen_swiotlb_init_late() is called by
pcifront_connect_and_init_dma, which does:

	if (!err && !swiotlb_nr_tbl()) {
		err = pci_xen_swiotlb_init_late();
		if (err)
			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
	}

pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
allocated yet, and the io_tlb_start != 0 check at the beginning of
xen_swiotlb_init will also fail. The code will take the normal
route, same as today. In short, there should be no effects on x86.

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-04 16:51       ` Stefano Stabellini
@ 2019-06-04 19:41         ` Boris Ostrovsky
  2019-06-05 14:13           ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 16+ messages in thread
From: Boris Ostrovsky @ 2019-06-04 19:41 UTC (permalink / raw)
  To: Stefano Stabellini; +Cc: jgross, xen-devel, Julien.Grall, konrad.wilk

On 6/4/19 12:51 PM, Stefano Stabellini wrote:
> On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
>> On 6/3/19 2:25 PM, Stefano Stabellini wrote:
>>> On Tue, 28 May 2019, Boris Ostrovsky wrote:
>>>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
>>>>> From: Stefano Stabellini <stefanos@xilinx.com>
>>>>>
>>>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
>>>>> We don't want to initialize it twice, which would trigger a second
>>>>> memory allocation. Moreover, the second memory pool is typically made of
>>>>> high pages and ends up replacing the original memory pool of low pages.
>>>>> As a side effect of this change, it is possible to have low pages in
>>>>> swiotlb-xen on arm64.
>>>>>
>>>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>>>> Has this been tested on x86?
>>> Yes, I managed to test it using QEMU. There are no effects on x86, as
>>> the check io_tlb_start != 0 returns false.
>> I wonder though whether this is always the case.  When we are called
>> from pci_xen_swiotlb_init_late() for example.
> In that case, pci_xen_swiotlb_init_late() is called by
> pcifront_connect_and_init_dma, which does:
>
> 	if (!err && !swiotlb_nr_tbl()) {
> 		err = pci_xen_swiotlb_init_late();
> 		if (err)
> 			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
> 	}
>
> pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
> 0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
> allocated yet, and the io_tlb_start != 0 check at the beginning of
> xen_swiotlb_init will also fail. The code will take the normal
> route, same as today. In short, there should be no effects on x86.


OK, thanks.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-04 19:41         ` Boris Ostrovsky
@ 2019-06-05 14:13           ` Konrad Rzeszutek Wilk
  2019-06-05 14:24             ` Juergen Gross
  0 siblings, 1 reply; 16+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-06-05 14:13 UTC (permalink / raw)
  To: Boris Ostrovsky; +Cc: jgross, xen-devel, Julien.Grall, Stefano Stabellini

On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote:
> On 6/4/19 12:51 PM, Stefano Stabellini wrote:
> > On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
> >> On 6/3/19 2:25 PM, Stefano Stabellini wrote:
> >>> On Tue, 28 May 2019, Boris Ostrovsky wrote:
> >>>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> >>>>> From: Stefano Stabellini <stefanos@xilinx.com>
> >>>>>
> >>>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
> >>>>> We don't want to initialize it twice, which would trigger a second
> >>>>> memory allocation. Moreover, the second memory pool is typically made of
> >>>>> high pages and ends up replacing the original memory pool of low pages.
> >>>>> As a side effect of this change, it is possible to have low pages in
> >>>>> swiotlb-xen on arm64.
> >>>>>
> >>>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> >>>> Has this been tested on x86?
> >>> Yes, I managed to test it using QEMU. There are no effects on x86, as
> >>> the check io_tlb_start != 0 returns false.
> >> I wonder though whether this is always the case.  When we are called
> >> from pci_xen_swiotlb_init_late() for example.
> > In that case, pci_xen_swiotlb_init_late() is called by
> > pcifront_connect_and_init_dma, which does:
> >
> > 	if (!err && !swiotlb_nr_tbl()) {
> > 		err = pci_xen_swiotlb_init_late();
> > 		if (err)
> > 			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
> > 	}
> >
> > pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
> > 0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
> > allocated yet, and the io_tlb_start != 0 check at the beginning of
> > xen_swiotlb_init will also fail. The code will take the normal
> > route, same as today. In short, there should be no effects on x86.
> 
> 
> OK, thanks.
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Pushed in devel/for-linus-5.2 and will eventually move it to stable and push to Linus next-week.

Are there any other patches I should pick up?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-05 14:13           ` Konrad Rzeszutek Wilk
@ 2019-06-05 14:24             ` Juergen Gross
  2019-06-13 14:23               ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 16+ messages in thread
From: Juergen Gross @ 2019-06-05 14:24 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk, Boris Ostrovsky
  Cc: xen-devel, Julien.Grall, Stefano Stabellini

On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote:
>> On 6/4/19 12:51 PM, Stefano Stabellini wrote:
>>> On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
>>>> On 6/3/19 2:25 PM, Stefano Stabellini wrote:
>>>>> On Tue, 28 May 2019, Boris Ostrovsky wrote:
>>>>>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
>>>>>>> From: Stefano Stabellini <stefanos@xilinx.com>
>>>>>>>
>>>>>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
>>>>>>> We don't want to initialize it twice, which would trigger a second
>>>>>>> memory allocation. Moreover, the second memory pool is typically made of
>>>>>>> high pages and ends up replacing the original memory pool of low pages.
>>>>>>> As a side effect of this change, it is possible to have low pages in
>>>>>>> swiotlb-xen on arm64.
>>>>>>>
>>>>>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>>>>>> Has this been tested on x86?
>>>>> Yes, I managed to test it using QEMU. There are no effects on x86, as
>>>>> the check io_tlb_start != 0 returns false.
>>>> I wonder though whether this is always the case.  When we are called
>>>> from pci_xen_swiotlb_init_late() for example.
>>> In that case, pci_xen_swiotlb_init_late() is called by
>>> pcifront_connect_and_init_dma, which does:
>>>
>>> 	if (!err && !swiotlb_nr_tbl()) {
>>> 		err = pci_xen_swiotlb_init_late();
>>> 		if (err)
>>> 			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
>>> 	}
>>>
>>> pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
>>> 0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
>>> allocated yet, and the io_tlb_start != 0 check at the beginning of
>>> xen_swiotlb_init will also fail. The code will take the normal
>>> route, same as today. In short, there should be no effects on x86.
>>
>>
>> OK, thanks.
>>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> Pushed in devel/for-linus-5.2 and will eventually move it to stable and push to Linus next-week.
> 
> Are there any other patches I should pick up?
> 

I think at least the first two patches from my series:

https://patchew.org/Xen/20190529090407.1225-1-jgross@suse.com/

are ready to go in.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-05 14:24             ` Juergen Gross
@ 2019-06-13 14:23               ` Konrad Rzeszutek Wilk
  2019-06-13 15:04                 ` Juergen Gross
  0 siblings, 1 reply; 16+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-06-13 14:23 UTC (permalink / raw)
  To: Juergen Gross
  Cc: xen-devel, Boris Ostrovsky, Stefano Stabellini, Julien.Grall

On Wed, Jun 05, 2019 at 04:24:06PM +0200, Juergen Gross wrote:
> On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote:
> > On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote:
> > > On 6/4/19 12:51 PM, Stefano Stabellini wrote:
> > > > On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
> > > > > On 6/3/19 2:25 PM, Stefano Stabellini wrote:
> > > > > > On Tue, 28 May 2019, Boris Ostrovsky wrote:
> > > > > > > On 5/28/19 6:48 PM, Stefano Stabellini wrote:
> > > > > > > > From: Stefano Stabellini <stefanos@xilinx.com>
> > > > > > > > 
> > > > > > > > On arm64 swiotlb is often (not always) already initialized by mem_init.
> > > > > > > > We don't want to initialize it twice, which would trigger a second
> > > > > > > > memory allocation. Moreover, the second memory pool is typically made of
> > > > > > > > high pages and ends up replacing the original memory pool of low pages.
> > > > > > > > As a side effect of this change, it is possible to have low pages in
> > > > > > > > swiotlb-xen on arm64.
> > > > > > > > 
> > > > > > > > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > > > > > > Has this been tested on x86?
> > > > > > Yes, I managed to test it using QEMU. There are no effects on x86, as
> > > > > > the check io_tlb_start != 0 returns false.
> > > > > I wonder though whether this is always the case.  When we are called
> > > > > from pci_xen_swiotlb_init_late() for example.
> > > > In that case, pci_xen_swiotlb_init_late() is called by
> > > > pcifront_connect_and_init_dma, which does:
> > > > 
> > > > 	if (!err && !swiotlb_nr_tbl()) {
> > > > 		err = pci_xen_swiotlb_init_late();
> > > > 		if (err)
> > > > 			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
> > > > 	}
> > > > 
> > > > pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
> > > > 0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
> > > > allocated yet, and the io_tlb_start != 0 check at the beginning of
> > > > xen_swiotlb_init will also fail. The code will take the normal
> > > > route, same as today. In short, there should be no effects on x86.
> > > 
> > > 
> > > OK, thanks.
> > > 
> > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > 
> > Pushed in devel/for-linus-5.2 and will eventually move it to stable and push to Linus next-week.
> > 
> > Are there any other patches I should pick up?
> > 
> 
> I think at least the first two patches from my series:
> 
> https://patchew.org/Xen/20190529090407.1225-1-jgross@suse.com/
> 
> are ready to go in.

#2 patch says:

	"> To be symmetric with setting the flag only after having made the region                                                                                              
	> contiguous, and to avoid (perhaps just theoretical) races, wouldn't it be                                                                                            
	> better to clear the flag before calling xen_destroy_contiguous_region()?                                                                                             
	> Even better would be a TestAndClear...() operation.                                                                                                                  

	I like that idea.
"
?

> 
> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-13 14:23               ` Konrad Rzeszutek Wilk
@ 2019-06-13 15:04                 ` Juergen Gross
  2019-06-13 21:00                   ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 16+ messages in thread
From: Juergen Gross @ 2019-06-13 15:04 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk
  Cc: Christoph Hellwig, xen-devel, Boris Ostrovsky,
	Stefano Stabellini, Julien.Grall

On 13.06.19 16:23, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 05, 2019 at 04:24:06PM +0200, Juergen Gross wrote:
>> On 05.06.19 16:13, Konrad Rzeszutek Wilk wrote:
>>> On Tue, Jun 04, 2019 at 03:41:40PM -0400, Boris Ostrovsky wrote:
>>>> On 6/4/19 12:51 PM, Stefano Stabellini wrote:
>>>>> On Mon, 3 Jun 2019, Boris Ostrovsky wrote:
>>>>>> On 6/3/19 2:25 PM, Stefano Stabellini wrote:
>>>>>>> On Tue, 28 May 2019, Boris Ostrovsky wrote:
>>>>>>>> On 5/28/19 6:48 PM, Stefano Stabellini wrote:
>>>>>>>>> From: Stefano Stabellini <stefanos@xilinx.com>
>>>>>>>>>
>>>>>>>>> On arm64 swiotlb is often (not always) already initialized by mem_init.
>>>>>>>>> We don't want to initialize it twice, which would trigger a second
>>>>>>>>> memory allocation. Moreover, the second memory pool is typically made of
>>>>>>>>> high pages and ends up replacing the original memory pool of low pages.
>>>>>>>>> As a side effect of this change, it is possible to have low pages in
>>>>>>>>> swiotlb-xen on arm64.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
>>>>>>>> Has this been tested on x86?
>>>>>>> Yes, I managed to test it using QEMU. There are no effects on x86, as
>>>>>>> the check io_tlb_start != 0 returns false.
>>>>>> I wonder though whether this is always the case.  When we are called
>>>>>> from pci_xen_swiotlb_init_late() for example.
>>>>> In that case, pci_xen_swiotlb_init_late() is called by
>>>>> pcifront_connect_and_init_dma, which does:
>>>>>
>>>>> 	if (!err && !swiotlb_nr_tbl()) {
>>>>> 		err = pci_xen_swiotlb_init_late();
>>>>> 		if (err)
>>>>> 			dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
>>>>> 	}
>>>>>
>>>>> pci_xen_swiotlb_init_late() is only called when swiotlb_nr_tbl() returns
>>>>> 0. If swiotlb_nr_tbl() returns 0, certainly the swiotlb has not been
>>>>> allocated yet, and the io_tlb_start != 0 check at the beginning of
>>>>> xen_swiotlb_init will also fail. The code will take the normal
>>>>> route, same as today. In short, there should be no effects on x86.
>>>>
>>>>
>>>> OK, thanks.
>>>>
>>>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>>
>>> Pushed in devel/for-linus-5.2 and will eventually move it to stable and push to Linus next-week.
>>>
>>> Are there any other patches I should pick up?
>>>
>>
>> I think at least the first two patches from my series:
>>
>> https://patchew.org/Xen/20190529090407.1225-1-jgross@suse.com/
>>
>> are ready to go in.
> 
> #2 patch says:
> 
> 	"> To be symmetric with setting the flag only after having made the region
> 	> contiguous, and to avoid (perhaps just theoretical) races, wouldn't it be
> 	> better to clear the flag before calling xen_destroy_contiguous_region()?
> 	> Even better would be a TestAndClear...() operation.
> 
> 	I like that idea.
> "
> ?

I was hoping for a clarification regarding the Xen specific page flag
names before posting V3.

As Christoph didn't react when I posted possible solutions I think I'll
just modify patch 3 according to Jan's comment and post V3.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-13 15:04                 ` Juergen Gross
@ 2019-06-13 21:00                   ` Konrad Rzeszutek Wilk
  2019-06-17  8:21                     ` Christoph Hellwig
  0 siblings, 1 reply; 16+ messages in thread
From: Konrad Rzeszutek Wilk @ 2019-06-13 21:00 UTC (permalink / raw)
  To: Juergen Gross
  Cc: Christoph Hellwig, xen-devel, Boris Ostrovsky,
	Stefano Stabellini, Julien.Grall

> > 
> > #2 patch says:
> > 
> > 	"> To be symmetric with setting the flag only after having made the region
> > 	> contiguous, and to avoid (perhaps just theoretical) races, wouldn't it be
> > 	> better to clear the flag before calling xen_destroy_contiguous_region()?
> > 	> Even better would be a TestAndClear...() operation.
> > 
> > 	I like that idea.
> > "
> > ?
> 
> I was hoping for a clarification regarding the Xen specific page flag
> names before posting V3.
> 
> As Christoph didn't react when I posted possible solutions I think I'll
> just modify patch 3 according to Jan's comment and post V3.

OK, will await that patchset. Thank you!

BTW, your patch #1 should be upstream now.
> 
> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [Xen-devel] [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64
  2019-06-13 21:00                   ` Konrad Rzeszutek Wilk
@ 2019-06-17  8:21                     ` Christoph Hellwig
  0 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2019-06-17  8:21 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk
  Cc: Juergen Gross, Stefano Stabellini, Christoph Hellwig,
	Julien.Grall, xen-devel, Boris Ostrovsky

On Thu, Jun 13, 2019 at 05:00:57PM -0400, Konrad Rzeszutek Wilk wrote:
> > As Christoph didn't react when I posted possible solutions I think I'll
> > just modify patch 3 according to Jan's comment and post V3.
> 
> OK, will await that patchset. Thank you!
> 
> BTW, your patch #1 should be upstream now.

Still not a big fan of the page flags in the common header, but please
go ahead for now if the mm folks are fine with it.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 22:48 [PATCH v2] xen/swiotlb: don't initialize swiotlb twice on arm64 Stefano Stabellini
2019-05-28 22:48 ` [Xen-devel] " Stefano Stabellini
2019-05-28 23:50 ` Boris Ostrovsky
2019-05-28 23:50   ` [Xen-devel] " Boris Ostrovsky
2019-06-03 18:25   ` Stefano Stabellini
2019-06-03 18:25     ` [Xen-devel] " Stefano Stabellini
2019-06-03 23:16     ` Boris Ostrovsky
2019-06-03 23:16       ` [Xen-devel] " Boris Ostrovsky
2019-06-04 16:51       ` Stefano Stabellini
2019-06-04 19:41         ` Boris Ostrovsky
2019-06-05 14:13           ` Konrad Rzeszutek Wilk
2019-06-05 14:24             ` Juergen Gross
2019-06-13 14:23               ` Konrad Rzeszutek Wilk
2019-06-13 15:04                 ` Juergen Gross
2019-06-13 21:00                   ` Konrad Rzeszutek Wilk
2019-06-17  8:21                     ` Christoph Hellwig

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@archiver.kernel.org
	public-inbox-index xen-devel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox