From: Julien Grall <julien@xen.org>
To: Oleksii <oleksii.kurochko@gmail.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v2 1/3] xen/riscv: introduce setup_initial_pages
Date: Mon, 27 Mar 2023 11:54:15 +0100 [thread overview]
Message-ID: <27fb1c9b-f504-092b-de2d-ed823f417b38@xen.org> (raw)
In-Reply-To: <dd8b038c00fba91d0e50d4bb8c98466dfd37ef01.camel@gmail.com>
On 27/03/2023 11:50, Oleksii wrote:
> Hello Julien,
Hi,
> On Tue, 2023-03-21 at 17:58 +0000, Julien Grall wrote:
>>> + /* Setup level0 table */
>>> + if ( !pte_is_valid(&zeroeth[index0]) )
>>
>> On the previous version, you said it should be checked for each
>> level.
>> But here you still only check for a single level.
>>
>> Furthermore, I would strongly suggest to also check the valid PTE is
>> the
>> same as you intend to write to catch any override (they are a pain to
>> debug).
>>
> Do you mean that I have to get a virtual address, extract the page
> table index bits from it, traverse the page table hierarchy to locate
> the PTE for the virtual address and the compare the gotten PTE address
> with zeroeh[index0]?
No. I was suggesting to check the PTE you intend to write is the exact
same that the one you are overwriting.
This could potentially be relaxed to allow permission flags to be changed.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-03-27 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 16:43 [PATCH v2 0/3] enable MMU for RISC-V Oleksii Kurochko
2023-03-16 16:43 ` [PATCH v2 1/3] xen/riscv: introduce setup_initial_pages Oleksii Kurochko
2023-03-20 16:41 ` Jan Beulich
2023-03-21 17:08 ` Oleksii
2023-03-22 8:12 ` Jan Beulich
2023-03-22 9:22 ` Oleksii
2023-03-21 17:58 ` Julien Grall
2023-03-22 8:19 ` Jan Beulich
2023-03-22 13:55 ` Julien Grall
2023-03-22 9:55 ` Oleksii
2023-03-22 14:21 ` Julien Grall
2023-03-23 11:18 ` Oleksii
2023-03-23 11:57 ` Julien Grall
2023-03-23 12:30 ` Oleksii
2023-03-23 12:44 ` Julien Grall
2023-03-27 10:50 ` Oleksii
2023-03-27 10:54 ` Julien Grall [this message]
2023-03-16 16:43 ` [PATCH v2 2/3] xen/riscv: setup initial pagetables Oleksii Kurochko
2023-03-20 17:03 ` Jan Beulich
2023-03-21 17:09 ` Oleksii
2023-03-16 16:43 ` [PATCH v2 3/3] xen/riscv: remove dummy_bss variable Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27fb1c9b-f504-092b-de2d-ed823f417b38@xen.org \
--to=julien@xen.org \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).